Merged
Conversation
lpahlavi
force-pushed
the
lpahlavi/update-ic-cdk
branch
5 times, most recently
from
b2d9b48 to
70b67d4
Compare
lpahlavi
changed the title
ic-cdk to v0.18.6ic-cdk to v0.18.6
lpahlavi
force-pushed
the
lpahlavi/update-ic-cdk
branch
2 times, most recently
from
29dda2a to
a1c03c0
Compare
lpahlavi
changed the base branch from
main
to
lpahlavi/standalone-basic-solana
lpahlavi
force-pushed
the
lpahlavi/standalone-basic-solana
branch
from
42aea94 to
e59b66b
Compare
lpahlavi
force-pushed
the
lpahlavi/update-ic-cdk
branch
4 times, most recently
from
ea5f6c0 to
0e08142
Compare
Cargo.toml
Outdated
| ic-agent = "0.44.3" | ||
| ic-agent-canister-runtime = { git = "https://github.com/dfinity/canhttp/", rev = "3d27f24df421cd7a25e8a38bb4cc117926e0e820" } | ||
| ic-canister-runtime = { git = "https://github.com/dfinity/canhttp/", rev = "3d27f24df421cd7a25e8a38bb4cc117926e0e820", features = ["wallet"] } | ||
| ic-cdk = "0.18.7" |
Contributor
There was a problem hiding this comment.
why doing the ic-cdk upgrade and the switch to the canhttp runtime into a single PR? I have the impression that it would be much easier to split this in 2:
- Upgrade to the new version of the ic-cdk
- Then, switch to canhttp runtime.
WDYT?
Contributor
Author
There was a problem hiding this comment.
@gregorydemay Good question. I initially wanted to split things as you proposed as well, but realized I would then have to adapt the Runtime trait and implementations to the breaking changes introduced by the ic-cdk v0.18.6 (e.g. define a new IcError type and return this instead of the old (RejectCode,String)).
If you think it makes sense, I could do it like this, but I thought it made more sense to leverage the fact we already have a runtime implementation that supports ic-cdk v0.18.6 in the ic-canister-runtime crate.
WDYT?
Contributor
Author
There was a problem hiding this comment.
@gregorydemay In the end I decided to split this up into 2 separate PRs. The first one, updating the ic-cdk to v0.19.0 is here: #251. It will require merging #249 first though due to the breaking changes in the client.
lpahlavi
changed the title
ic-cdk to v0.18.6
lpahlavi
force-pushed
the
lpahlavi/update-ic-cdk
branch
2 times, most recently
from
7fdd826 to
ed9a70c
Compare
lpahlavi
changed the base branch from
lpahlavi/standalone-basic-solana
to
lpahlavi/bump-ic-cdk-to-v0.19.0
lpahlavi
force-pushed
the
lpahlavi/bump-ic-cdk-to-v0.19.0
branch
2 times, most recently
from
2a619bb to
64dc327
Compare
lpahlavi
force-pushed
the
lpahlavi/update-ic-cdk
branch
from
9bfa70f to
953a817
Compare
lpahlavi
force-pushed
the
lpahlavi/update-ic-cdk
branch
3 times, most recently
from
103cd10 to
a763614
Compare
lpahlavi
force-pushed
the
lpahlavi/update-ic-cdk
branch
from
29d6c7a to
45a0680
Compare
Merged
lpahlavi
added a commit
that referenced
this pull request
Jan 12, 2026
## 🤖 New release * `sol_rpc_types`: 3.0.0 -> 4.0.0 * `sol_rpc_canister`: 1.3.0 * `sol_rpc_client`: 3.0.0 -> 3.1.0 <details><summary><i><b>Changelog</b></i></summary><p> ## `sol_rpc_types` <blockquote> ## [3.1.0] - 2026-01-12 ### Changed - Bump `ic-cdk` to v0.19.0 ([#251](#251)) - Upgrade various dependencies ([#260](#260)) [3.1.0]: https://github.com/dfinity/sol-rpc-canister/compare/3.0.0..3.1.0 </blockquote> ## `sol_rpc_canister` <blockquote> ## [1.3.0] - 2026-01-12 ### Changed - Bump `ic-cdk` to v0.19.0 ([#251](#251)) - Upgrade various dependencies ([#260](#260)) ### Fixed - Do not ignore `response_size_estimate` for `getBlock` endpoint ([#236](#236)) [1.3.0]: sol_rpc_canister-v1.2.0...sol_rpc_canister-v1.3.0 </blockquote> ## `sol_rpc_client` <blockquote> ## [4.0.0] - 2026-01-12 ### Changed - Use `ic_canister_runtime::Runtime` instead of local `Runtime` trait ([#248](#248)) - **BREAKING:** Bump `ic-cdk` to v0.19.0. See PR description for more details on the breaking changes. ([#251](#251)) - Upgrade various dependencies ([#260](#260)) ### Fixed - **BREAKING:** Calculate default request cost before sending. See PR description for more details on the breaking changes. ([#256](#256)) [4.0.0]: https://github.com/dfinity/sol-rpc-canister/compare/3.0.0..4.0.0 </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Louis Pahlavi <louis.pahlavi@dfinity.org> Co-authored-by: Louis Pahlavi <louis.pahlavi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(DEFI-2462) This PR replaces the local
Runtimetrait by the one in the newic-canister-runtimecrate and uses the relevant implementations in theic-agent-canister-runtimeandic-pocket-canister-runtimecrates.A follow-up PR will clean-up the HTTP mocking infrastructure to switch to the one from
ic-pocket-canister-runtime.