test: integration tests that RPC config is respected#237
Merged
Conversation
lpahlavi
changed the base branch from
main
to
lpahlavi/do-not-ignore-response-size-estimate-for-get-block
lpahlavi
changed the title
lpahlavi
force-pushed
the
lpahlavi/rpc-config-int-tests
branch
from
1af7410 to
d93ac11
Compare
Base automatically changed from
lpahlavi/do-not-ignore-response-size-estimate-for-get-block
to
main
September 26, 2025 13:10
gregorydemay
approved these changes
Oct 3, 2025
Contributor
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks a lot @lpahlavi for this PR and sorry for the delay in reviewing it. Couple of minor comments but otherwise LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds integration tests to ensure that RPC config parameters are correctly respected when invoking the various SOL RPC canister endpoints. It also introduces a missing integration test for
getTransaction.