Conversation
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Nice clean-up @lpahlavi !
|
|
||
| /// Creates an instruction to run the [`Transfer` instruction](https://github.com/solana-program/token/blob/main/interface/src/instruction.rs) | ||
| /// in the SPL Token program. | ||
| pub fn transfer_instruction_with_program_id( |
There was a problem hiding this comment.
I had a quick look actually. The problem is the spl-token crate still depends on the old v2 solana-* crates... This means we can't use it (yet). I thought I'd take care of the low-hanging fruits for now.
There was a problem hiding this comment.
I see, thanks for having checked!
There was a problem hiding this comment.
Dug a bit deeper, turns out actually there is a different crate that did update their dependencies 💪 So done as well!
There was a problem hiding this comment.
Ok, well it turns out this would have been too easy... Actually the spl-token-2022-interface crate has a transitive dependency on wasm-bindgen through solana-zk-sdk. Also in case one would be tempted to use the spl-token-interface crate, it does not work with SPL 2022 tokens (see this check).
So I guess back to hardcoded transfer instructions 🫠
lpahlavi
changed the title
spl-associated-token-account-interfacespl-* crates
lpahlavi
deleted the
lpahlavi/use-spl-associated-token-account-interface
branch
2 participants
(XC-297) This is a follow-up to #197. Now that the
solana-sdkdependencies are upgraded to v3, use thespl_associated_token_account_interfacecrate to compute associated token addresses (ATAs) andspl-token-interfacecrate to create an SPL transfer instruction in thebasic_solanaexample and integration tests.