Conversation
nmattia
changed the title
basvandijk
approved these changes
Aug 21, 2020
Contributor
basvandijk
left a comment
basvandijk
left a comment
There was a problem hiding this comment.
Looks good. Let's do it!
Make sure to update the CD job registration soon after this is merged.
This moves the publish job to the `ci/` directory and make it platform-independent. This means the jobs can now be run locally like so: ``` shell $ nix run -f ./ci/ci.nix publish.dfx -c activate ``` NOTE: The publish job will need to be changed; the target is now `publish.dfx` (was `publish.dfx.x86_64-linux`). In theory we need to make sure that machines for (1) evaluating and (2) deploying have the same platform; in practice this is always the case.
basvandijk
added a commit
that referenced
this pull request
Aug 26, 2020
#949 removed the `x86_64-linux` attribute of the `publish.dfx.x86_64-linux` job which broke evaluation of `ci/release.nix`.
basvandijk
added a commit
that referenced
this pull request
Aug 26, 2020
#949 removed the `x86_64-linux` attribute of the `publish.dfx.x86_64-linux` job which broke evaluation of `ci/release.nix`.
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2020
#949 removed the `x86_64-linux` attribute of the `publish.dfx.x86_64-linux` job which broke evaluation of `ci/release.nix`.
dfinity-bot
added a commit
that referenced
this pull request
Jul 4, 2021
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@34e9832a...23d8630f](rustsec/advisory-db@34e9832...23d8630) * [`23d8630f`](rustsec/advisory-db@23d8630) Bump `rustsec-admin` to v0.5.1 ([RustSec/advisory-db#949](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/949))
mergify bot
pushed a commit
that referenced
this pull request
Jul 4, 2021
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@34e9832a...23d8630f](rustsec/advisory-db@34e9832...23d8630) * [`23d8630f`](rustsec/advisory-db@23d8630) Bump `rustsec-admin` to v0.5.1 ([RustSec/advisory-db#949](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/949))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the publish job to the
ci/directory and make itplatform-independent. This means the jobs can now be run locally like
so:
NOTE: The publish job will need to be changed; the target is now
publish.dfx(waspublish.dfx.x86_64-linux). In theory we need tomake sure that machines for (1) evaluating and (2) deploying have the
same platform; in practice this is always the case.