refactor: move rust agent to its own repo#876
Merged
mergify[bot] merged 31 commits intomasterfrom Aug 10, 2020
Merged
Conversation
nomeata
reviewed
Jul 27, 2020
p-shahi
approved these changes
Aug 5, 2020
The following used to work:
```
nix-repl> builtins.fetchGit { url = "ssh://git@github.com/dfinity-lab/agent-rust"; ref = "v0.6.3"; }
{ outPath = "/nix/store/rrlmgrf9z0nm9jzbimbsl6rpj96ij9yn-source"; rev = "5b2fab20e1902f8709d1b09fcb6f5ee9feb0084e"; revCount = 42; shortRev = "5b2fab2"; }
```
However, due to a Nix upgrade on Hydra this doesn't seem to work
anymore:
```
nix-repl> builtins.fetchGit { url = "ssh://git@github.com/dfinity-lab/agent-rust.git"; ref = "v0.6.3"; }
fetching Git repository 'ssh://git@github.com/dfinity-lab/agent-rust.git'fatal: couldn't find remote ref refs/heads/v0.6.3
error: --- Error ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- nix
program 'git' failed with exit code 128
```
I'm not sure this is intended behaviour but it could be that Nix wants
to have a revision in order to guarantee that the source doesn't
change:
```
nix-repl> builtins.fetchGit { url = "ssh://git@github.com/dfinity-lab/agent-rust"; rev = "5b2fab20e1902f8709d1b09fcb6f5ee9feb0084e"; ref = "0.6"; }
{ lastModified = 1596813025; lastModifiedDate = "20200807151025"; narHash = "sha256-LJY3PJeTFaR3nn0/SAxbAOhogkcQS3JkHUiyOY14lWA="; outPath = "/nix/store/rrlmgrf9z0nm9jzbimbsl6rpj96ij9yn-source"; rev = "5b2fab20e1902f8709d1b09fcb6f5ee9feb0084e"; revCount = 42; shortRev = "5b2fab2"; submodules = false; }
```
Note that if the revision is not reachable from `master` it's also
required to specify a branch. Unfortunately this does currently raise
a warning in cargo:
```
$ cargo build
warning: /Users/bas/d/sdk/hansl/move-ic-agent-to-own-repo/src/ic_identity_manager/Cargo.toml: dependency (ic-agent) specification is ambiguous. Only one of `branch`, `tag` or `rev` is allowed. This will be considered an error in future versions
warning: /Users/bas/d/sdk/hansl/move-ic-agent-to-own-repo/src/dfx/Cargo.toml: dependency (ic-agent) specification is ambiguous. Only one of `branch`, `tag` or `rev` is allowed. This will be considered an error in future versions
```
basvandijk
reviewed
Aug 10, 2020
dfinity-bot
added a commit
that referenced
this pull request
Apr 20, 2021
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@60455ec8...5b3dcb83](rustsec/advisory-db@60455ec...5b3dcb8) * [`5b3dcb83`](rustsec/advisory-db@5b3dcb8) Yank advisories for once-again maintained `dirs`/`directories` crates ([RustSec/advisory-db#876](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/876))
mergify bot
pushed a commit
that referenced
this pull request
Apr 20, 2021
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@60455ec8...5b3dcb83](rustsec/advisory-db@60455ec...5b3dcb8) * [`5b3dcb83`](rustsec/advisory-db@5b3dcb8) Yank advisories for once-again maintained `dirs`/`directories` crates ([RustSec/advisory-db#876](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/876))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf. #858