Basic setup for building JS user library with Nix#61
Conversation
eftychis
left a comment
eftychis
left a comment
There was a problem hiding this comment.
LGTM -- not familiar with napalm -- seems straightforward.
| @@ -0,0 +1,5 @@ | |||
| = js-user-library | |||
There was a problem hiding this comment.
Can we move this into a userlib/ and then separate by language?
There was a problem hiding this comment.
I would like to do this later if necessary since it will make the task of breaking up #56 even more complicated
There was a problem hiding this comment.
Do you want us to rubberstamp every PR with my comments going to "later"? That's as if the PR was the 21k lines one.
There was a problem hiding this comment.
Not at all, but this seems like an arbitrary decision that can wait until later.
| @@ -1,2 +1,14 @@ | |||
| { | |||
| "napalm": { | |||
There was a problem hiding this comment.
Do we need this as part of our repo, or can we add it to common?
There was a problem hiding this comment.
It's specifically for building Node.js packages so I think it makes the most sense here for now. I can move it to common if other repos start using it.
| self: super: { | ||
| dfinity-sdk = rec { | ||
| packages = rec { | ||
| js-user-library = super.callPackage ../../js-user-library/package.nix { |
There was a problem hiding this comment.
I'd rather have user-library-js or even better userlib.js.
There was a problem hiding this comment.
I would prefer to follow up with this later if necessary as well
|
I'll let @eftychis do the reviews of these, as I will be away for the next three weeks and he'll have to get familiar with the code (as well as work with you on it). |
3 participants
Extracted from #56