fix: build generates different IDs every time#598
Merged
mergify[bot] merged 2 commits intomasterfrom Apr 27, 2020
Merged
Conversation
Contributor
lsgunnlsgunn
left a comment
lsgunnlsgunn
left a comment
There was a problem hiding this comment.
The commit description seems misleading to me. Doesn't this make generating a different ID with each build false by default?
Contributor
Author
|
The other way around. There was a bug introduced (might be during my refactor of the build system) that two |
hansl
changed the title
chenyan-dfinity
approved these changes
Apr 27, 2020
dfinity-bot
added a commit
that referenced
this pull request
Jan 19, 2021
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@b08a98ac...89b9e106](rustsec/advisory-db@b08a98a...89b9e10) * [`6ea698b8`](rustsec/advisory-db@6ea698b) lazy-init: Missing Send bound for Lazy (khuey/lazy-init[RustSec/advisory-db#9](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/9)) * [`6703edaf`](rustsec/advisory-db@6703eda) apply review changes * [`47d589b0`](rustsec/advisory-db@47d589b) Assigned RUSTSEC-2021-0004 to lazy-init * [`efb79eff`](rustsec/advisory-db@efb79ef) report double drop issue in glsl-layout * [`47061ba3`](rustsec/advisory-db@47061ba) Report 0025-im to RustSec * [`4cf4c549`](rustsec/advisory-db@4cf4c54) Assigned RUSTSEC-2021-0005 to glsl-layout * [`b2a7af1c`](rustsec/advisory-db@b2a7af1) Assigned RUSTSEC-2020-0096 to im * [`1613b211`](rustsec/advisory-db@1613b21) Report 0063-xcb to RustSec * [`ea867420`](rustsec/advisory-db@ea86742) Assigned RUSTSEC-2020-0097 to xcb * [`d7de84ed`](rustsec/advisory-db@d7de84e) Add advisory for data race in rusb ([RustSec/advisory-db#580](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/580)) * [`3fbe0648`](rustsec/advisory-db@3fbe064) Assigned RUSTSEC-2020-0098 to rusb ([RustSec/advisory-db#581](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/581)) * [`c9886554`](rustsec/advisory-db@c988655) Add advisory for data race in aovec ([RustSec/advisory-db#528](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/528)) * [`315e464c`](rustsec/advisory-db@315e464) Assigned RUSTSEC-2020-0099 to aovec ([RustSec/advisory-db#596](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/596)) * [`97aa97b0`](rustsec/advisory-db@97aa97b) cache: exposes internally used raw pointer ([RustSec/advisory-db#543](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/543)) * [`89b9e106`](rustsec/advisory-db@89b9e10) Assigned RUSTSEC-2021-0006 to cache ([RustSec/advisory-db#598](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/598))
mergify bot
pushed a commit
that referenced
this pull request
Jan 19, 2021
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@b08a98ac...89b9e106](rustsec/advisory-db@b08a98a...89b9e10) * [`6ea698b8`](rustsec/advisory-db@6ea698b) lazy-init: Missing Send bound for Lazy (khuey/lazy-init[RustSec/advisory-db#9](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/9)) * [`6703edaf`](rustsec/advisory-db@6703eda) apply review changes * [`47d589b0`](rustsec/advisory-db@47d589b) Assigned RUSTSEC-2021-0004 to lazy-init * [`efb79eff`](rustsec/advisory-db@efb79ef) report double drop issue in glsl-layout * [`47061ba3`](rustsec/advisory-db@47061ba) Report 0025-im to RustSec * [`4cf4c549`](rustsec/advisory-db@4cf4c54) Assigned RUSTSEC-2021-0005 to glsl-layout * [`b2a7af1c`](rustsec/advisory-db@b2a7af1) Assigned RUSTSEC-2020-0096 to im * [`1613b211`](rustsec/advisory-db@1613b21) Report 0063-xcb to RustSec * [`ea867420`](rustsec/advisory-db@ea86742) Assigned RUSTSEC-2020-0097 to xcb * [`d7de84ed`](rustsec/advisory-db@d7de84e) Add advisory for data race in rusb ([RustSec/advisory-db#580](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/580)) * [`3fbe0648`](rustsec/advisory-db@3fbe064) Assigned RUSTSEC-2020-0098 to rusb ([RustSec/advisory-db#581](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/581)) * [`c9886554`](rustsec/advisory-db@c988655) Add advisory for data race in aovec ([RustSec/advisory-db#528](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/528)) * [`315e464c`](rustsec/advisory-db@315e464) Assigned RUSTSEC-2020-0099 to aovec ([RustSec/advisory-db#596](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/596)) * [`97aa97b0`](rustsec/advisory-db@97aa97b) cache: exposes internally used raw pointer ([RustSec/advisory-db#543](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/543)) * [`89b9e106`](rustsec/advisory-db@89b9e10) Assigned RUSTSEC-2021-0006 to cache ([RustSec/advisory-db#598](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/598))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug introduced during refactoring that made
dfx buildgenerate the same IDs. This PR fixes it.