Skip to content

test: add a bit of e2e library to help with readability#58

Merged
hansl merged 5 commits intomasterfrom
hansl/e2e-asserts
Oct 8, 2019
Merged

test: add a bit of e2e library to help with readability#58
hansl merged 5 commits intomasterfrom
hansl/e2e-asserts

Conversation

@hansl
Copy link
Contributor

@hansl hansl commented Oct 8, 2019

Batslib is a library thats not distributed on Nix, and assertions are custom
made for this project.

@matthewhammer Let me know what you think. I think this is a step in a good direction.

Batslib is a library thats not distributed on Nix, and assertions are custom
made for this project.
@hansl hansl requested a review from matthewhammer October 8, 2019 15:58
@hansl hansl requested a review from a team as a code owner October 8, 2019 15:58
@paulyoung
Copy link
Contributor

Batslib is a library thats not distributed on Nix

We can probably use fetchGit, fetchZip, etc to pull in the source

@hansl
Copy link
Contributor Author

hansl commented Oct 8, 2019

I'll try.

@hansl
Copy link
Contributor Author

hansl commented Oct 8, 2019

I succeeded. Please take another look.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice.

@hansl hansl merged commit 1990d78 into master Oct 8, 2019
@hansl hansl deleted the hansl/e2e-asserts branch October 8, 2019 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants