Conversation
nmattia
left a comment
nmattia
left a comment
There was a problem hiding this comment.
I don't understand, where is shellcheck running now?
| @@ -11,10 +11,5 @@ let | |||
| ci = import ./ci.nix { inherit src releaseVersion; }; | |||
| in | |||
| if !doRelease then {} else { | |||
There was a problem hiding this comment.
do we still need the doRelease?
There was a problem hiding this comment.
Yes, nothing changed in that regard.
We still only want to build (and thus run) the publish.dfx.x86_64-linux job when there was an actual release.
basvandijk
force-pushed
the
basvandijk/remove-blobules-publishing-code
branch
from
17e25c8 to
8921189
Compare
* refactors the `install.sh` Nix derivations to be easier to follow. * Remove the hack for shellcheck local lint rules and makes sure shellcheck and shfmt are correctly applied to the script. * Fixes linting errors that arose during the above step. * Slightly adapt `publish.nix` to copy `manifest.json` directly from a local path instead of from the `install.sh` derivation. There's no reason for these to be coupled like this. * Because of the above the `s3cp` utility had to be refactored. Before it took a `pkg`, `path` and `dstDir` parameter. Now this is simplified to a `src` and `dst` parameter.
basvandijk
force-pushed
the
basvandijk/refactor-install
branch
from
69bf4a3 to
c659e01
Compare
basvandijk
changed the base branch from
basvandijk/remove-blobules-publishing-code
to
master
It's running here. |
|
Thanks for the review @hansl. BTW in other repos like |
|
It did (I made sure of that), I think you edited your PR description (adding the last example) after the facts, no? |
3 participants
Commit Message
refactor: the install.sh derivation
refactors the
install.shNix derivations to be easier to follow.Remove the hack for shellcheck local lint rules and makes sure
shellcheck and shfmt are correctly applied to the script.
Fixes linting errors that arose during the above step.
Slightly adapt
publish.nixto copymanifest.jsondirectly from alocal path instead of from the
install.shderivation. There's noreason for these to be coupled like this.
Because of the above the
s3cputility had to be refactored. Beforeit took a
pkg,pathanddstDirparameter. Now this is simplifiedto a
srcanddstparameter.Make
install.shexecutable so we can directly test it using: