refactor: remove blobules publishing code#566
Merged
mergify[bot] merged 1 commit intomasterfrom Apr 14, 2020
Merged
Conversation
nmattia
reviewed
Apr 14, 2020
Contributor
nmattia
left a comment
nmattia
left a comment
There was a problem hiding this comment.
Looks good, I'm just wondering if we use the the_release
|
|
||
| tar -cvzf "$out/$the_release" -C $collection/ . | ||
|
|
||
| # Creating the manifest |
Contributor
There was a problem hiding this comment.
do we still need the release tarball? do we do anything with that?
Contributor
Author
There was a problem hiding this comment.
Yes we upload it to the CDN.
Contributor
There was a problem hiding this comment.
what about inlining this in the CD job? i.e. move this to publish.nix, or move the content of publish.nix over here
Contributor
Author
There was a problem hiding this comment.
I think it's indeed a good idea to inline this into publish.nix.
I'll do that in: #568 (which is based on this).
nmattia
approved these changes
Apr 14, 2020
Since we now publish the SDK to the https://download.dfinity.systems CDN we don't need to publish to blobules anymore. So this commit removes the code related to blobules publishing.
basvandijk
force-pushed
the
basvandijk/remove-blobules-publishing-code
branch
from
17e25c8 to
8921189
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we now publish the SDK to the https://download.dfinity.systems
CDN we don't need to publish to blobules anymore. So this commit
removes the code related to blobules publishing.