Skip to content

Comments

Clap v3 configuration abstraction for bootstrap command.#564

Closed
enzoh wants to merge 6 commits intomasterfrom
enzoh/clap-bootstrap
Closed

Clap v3 configuration abstraction for bootstrap command.#564
enzoh wants to merge 6 commits intomasterfrom
enzoh/clap-bootstrap

Conversation

@enzoh
Copy link
Contributor

@enzoh enzoh commented Apr 13, 2020

No description provided.

@enzoh enzoh requested a review from a team as a code owner April 13, 2020 17:49
@basvandijk
Copy link
Contributor

@enzoh note that the eval failure
error: "access to URI 'https://github.com/clap-rs/clap' is forbidden in restricted mode"
is due to the fact that naersk fetches all git sources using builtins.fetchGit which is only allowed to fetch from this list of allowed URIs.

So you have 3 options:

  1. Clone clap to our dfinity-lab organization which is allowed.

  2. Extend the allowed-uris list with https://github.com/clap-rs/clap.

  3. Wait till your desired revision of clap is released to crates.io.

@hansl
Copy link
Contributor

hansl commented Apr 23, 2020

@enzoh Are you still working on this?

@enzoh
Copy link
Contributor Author

enzoh commented Apr 23, 2020

Hey, I could not get the hybrid approach to pass e2e tests, and spent significant time trying to make it work. My time is split, with the majority going to TikTok. Will try to revisit this over the weekend, and see where I get, but it's looking like we may need to upgrade all commands before merging to master is feasible.

@enzoh
Copy link
Contributor Author

enzoh commented Apr 23, 2020

To clarify next steps then. I would create another PR for build command that branches from this branch. Then the same for cache command, and etc. Finally, we would need to review all of them together and verify that e2e passes as expected.

@ghost
Copy link

ghost commented Oct 14, 2020

Closing this PR as it hasn't been updated in the last 60 days. Please reopen if this work is still relevant.

@ghost ghost closed this Oct 14, 2020
@lwshang lwshang deleted the enzoh/clap-bootstrap branch July 29, 2022 19:00
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants