Conversation
hansl
left a comment
There was a problem hiding this comment.
LGTM, assuming it passes CI
|
@hansl No, it does not pass CI. Somehow dfx submits |
ccd8bdf to
d19e48f
Compare
c2b66fd to
7d1e836
Compare
|
Having resolved the problems, I think it is basically unmaintainable not to share a crate for http request/response data types between sdk and replica. What is the plan going forward? |
43372b8 to
95c4790
Compare
| } | ||
| #[derive(Debug, Deserialize, PartialEq, Eq)] | ||
| #[serde(untagged)] | ||
| pub enum Replied { |
There was a problem hiding this comment.
Not sure what the difference is between Option<Blob> and this data type (as far as serde is concerned they encode to the same data).
There was a problem hiding this comment.
It was copied from http_handler, and I was not familiar with the motivation of changing it. However, it is an enum with flipped order (Empty comes last, where in Option type None comes first), so it does not decode to the same thing.
There was a problem hiding this comment.
They encode to the same interface { arg?: Blob }. Making arg an Option<Blob> results in the same encoding (which is what we had before this PR).
My concern is that this PR touches more than the minimum to make it work.
95c4790 to
63e4c8d
Compare
63e4c8d to
75c471c
Compare
|
This PR breaks userlib. |
|
Very likely userlib will have to adapt to the request/response data type changes from http_handler. How do I reproduce the error you had? @chenyan-dfinity |
|
Likely. You can run |
@pikajude noticed some problem, so I'm trying to see if they can be fixed.