refactor: Add e2e for principal identifier used#520
Closed
Conversation
Contributor
chenyan-dfinity
left a comment
chenyan-dfinity
left a comment
There was a problem hiding this comment.
I don't think we are ready for e2e. Need something like #393 to support principal in dfx. Haven't got time around to finish the PR though.
| @@ -0,0 +1,5 @@ | |||
| actor PrincipalId { | |||
| public shared(ctx) func get_principal_id() : async [Word32] { | |||
Contributor
There was a problem hiding this comment.
The return type is async Principal
Contributor
Author
|
We already do (not exposed to user yet). The replica doesn't fully yet. Or maybe I am misunderstanding what you are saying? |
Contributor
|
The Motoko code you write for test won't be decoded properly by dfx. It is returning |
Contributor
|
@eftychis Is this still being worked on? |
Contributor
Author
|
I can/shall rebase it. @hansl |
Contributor
|
This PR is months ago. Last comment was 2 months ago (and not adressed). I'll close and we can reopen later. I'm just doing a cleanup. |
dfinity-bot
added a commit
that referenced
this pull request
Dec 8, 2020
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@a24932e2...bd3cb8dd](rustsec/advisory-db@a24932e...bd3cb8d) * [`61d315ae`](rustsec/advisory-db@61d315a) Renamed crates ([RustSec/advisory-db#518](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/518)) * [`ed9dba32`](rustsec/advisory-db@ed9dba3) Assigned RUSTSEC-2020-0083 to safe_app, RUSTSEC-2020-0084 to safe_authenticator, RUSTSEC-2020-0085 to safe_vault, RUSTSEC-2020-0086 to safe_core ([RustSec/advisory-db#520](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/520)) * [`639d1b1b`](rustsec/advisory-db@639d1b1) Report 0047-try-mutex to RustSec ([RustSec/advisory-db#517](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/517)) * [`f17cd12f`](rustsec/advisory-db@f17cd12) Assigned RUSTSEC-2020-0087 to try-mutex ([RustSec/advisory-db#521](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/521)) * [`bd3cb8dd`](rustsec/advisory-db@bd3cb8d) Report 0050-magnetic to RustSec ([RustSec/advisory-db#519](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/519))
mergify bot
pushed a commit
that referenced
this pull request
Dec 8, 2020
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@a24932e2...bd3cb8dd](rustsec/advisory-db@a24932e...bd3cb8d) * [`61d315ae`](rustsec/advisory-db@61d315a) Renamed crates ([RustSec/advisory-db#518](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/518)) * [`ed9dba32`](rustsec/advisory-db@ed9dba3) Assigned RUSTSEC-2020-0083 to safe_app, RUSTSEC-2020-0084 to safe_authenticator, RUSTSEC-2020-0085 to safe_vault, RUSTSEC-2020-0086 to safe_core ([RustSec/advisory-db#520](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/520)) * [`639d1b1b`](rustsec/advisory-db@639d1b1) Report 0047-try-mutex to RustSec ([RustSec/advisory-db#517](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/517)) * [`f17cd12f`](rustsec/advisory-db@f17cd12) Assigned RUSTSEC-2020-0087 to try-mutex ([RustSec/advisory-db#521](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/521)) * [`bd3cb8dd`](rustsec/advisory-db@bd3cb8d) Report 0050-magnetic to RustSec ([RustSec/advisory-db#519](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/519))
dfinity-bot
added a commit
that referenced
this pull request
Apr 20, 2022
## Changelog for common: Branch: master Commits: [dfinity-lab/common@754180ab...6d8c79f0](https://github.com/dfinity-lab/common/compare/754180ab7b067fd06433ce4c498c9677b56f32fd...6d8c79f0752b092e2319e6f2f163a1477b205863) * [`6d8c79f0`](https://github.com/dfinity-lab/common/commit/6d8c79f0752b092e2319e6f2f163a1477b205863) Add SSH key for Maksym Arutyunyan ([dfinity-lab/common#520](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/520))
mergify bot
pushed a commit
that referenced
this pull request
Apr 20, 2022
## Changelog for common: Branch: master Commits: [dfinity-lab/common@754180ab...6d8c79f0](https://github.com/dfinity-lab/common/compare/754180ab7b067fd06433ce4c498c9677b56f32fd...6d8c79f0752b092e2319e6f2f163a1477b205863) * [`6d8c79f0`](https://github.com/dfinity-lab/common/commit/6d8c79f0752b092e2319e6f2f163a1477b205863) Add SSH key for Maksym Arutyunyan ([dfinity-lab/common#520](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/520))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(not sure what the right keyword is. Do we have a testing one?)