Conversation
ghost
self-assigned this
ghost
marked this pull request as ready for review
Author
|
Hey @hansl , can you leave a review here but not approve yet? |
hansl
suggested changes
Mar 13, 2020
Contributor
hansl
left a comment
hansl
left a comment
There was a problem hiding this comment.
Requesting changes. Because why not? I’m just drunk on reviewer power!
Author
|
I've made your requested changes, under protest. Review again, @hansl ? |
dfinity-bot
added a commit
that referenced
this pull request
Oct 31, 2020
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@09a8d7b2...a0e59ff2](rustsec/advisory-db@09a8d7b...a0e59ff) * [`a36b1185`](rustsec/advisory-db@a36b118) Add advisory for data race fix in futures-util ([RustSec/advisory-db#455](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/455)) * [`9cd2504f`](rustsec/advisory-db@9cd2504) Assigned RUSTSEC-2020-0059 to futures-util ([RustSec/advisory-db#456](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/456)) * [`b78fac19`](rustsec/advisory-db@b78fac1) Bumped create-pull-request github action to v3 ([RustSec/advisory-db#457](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/457)) * [`6a31581e`](rustsec/advisory-db@6a31581) Add advisory for use-after-free in futures-util task::waker * [`8c7efa1d`](rustsec/advisory-db@8c7efa1) Add advisory for potential null pointer deref in futures-task * [`47bfd9f2`](rustsec/advisory-db@47bfd9f) Add advisory for unsound Sync implemention on FuturesUnordered in futures-util * [`338f0977`](rustsec/advisory-db@338f097) Assigned RUSTSEC-2020-0060 to futures-task * [`e4784fd3`](rustsec/advisory-db@e4784fd) Assigned RUSTSEC-2020-0061 to futures-task * [`52cd1035`](rustsec/advisory-db@52cd103) Assigned RUSTSEC-2020-0062 to futures-util
dfinity-bot
added a commit
that referenced
this pull request
Aug 27, 2021
## Changelog for common: Branch: master Commits: [dfinity-lab/common@87104afb...e80cbd2e](https://github.com/dfinity-lab/common/compare/87104afb2aa76f1cf8f6709328c1a2116f273147...e80cbd2eaea492de7c573e8ed17f972b7f67a8f8) * [`e80cbd2e`](https://github.com/dfinity-lab/common/commit/e80cbd2eaea492de7c573e8ed17f972b7f67a8f8) Replace YAP's SSH key ([dfinity-lab/common#456](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/456))
mergify bot
pushed a commit
that referenced
this pull request
Aug 27, 2021
## Changelog for common: Branch: master Commits: [dfinity-lab/common@87104afb...e80cbd2e](https://github.com/dfinity-lab/common/compare/87104afb2aa76f1cf8f6709328c1a2116f273147...e80cbd2eaea492de7c573e8ed17f972b7f67a8f8) * [`e80cbd2e`](https://github.com/dfinity-lab/common/commit/e80cbd2eaea492de7c573e8ed17f972b7f67a8f8) Replace YAP's SSH key ([dfinity-lab/common#456](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/456))
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.