Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make integration #4083

Open
wants to merge 457 commits into
base: master
Choose a base branch
from
Open

Conversation

vporton
Copy link
Contributor

@vporton vporton commented Jan 28, 2025

Description

  • Added flags like --no-compile to deploy and generate and --no-deps (don't compile dependencies) to build.
  • Added command rules that outputs GNU Make rules.

Then rules can be used:

  • canister@NAME - compile a canister.
  • deploy@NAME - deploy a canister.
  • generate@NAME - generate bindings for a canister.

Implementation note: I added argument no_deps to many functions. This is a non-elegant code and I am asking you to advise me what can be done.

I will be busy with another project. Maybe, somebody can maintain this my code meanwhile?

My proposal is to merge this PR ASAP, to ease maintaining. It contains experimental features, but probably won't disturb using other (non-experimental) features. However, some code was heavily changed.

How Has This Been Tested?

I ran tests for compiling my (temporarily closed source) repository.
I will inform you, when I will test it on open source software.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@vporton
Copy link
Contributor Author

vporton commented Jan 29, 2025

I've tested it on this dapp: https://github.com/vporton/zondirectory2 (it seems to work without except that some canisters (personhood) are still recompiled twice) - full compilation became ~4x faster, partial recompilation/deployment is up to tens times faster. I am going to use my modified DFX in production of zondirectory2.

@vporton
Copy link
Contributor Author

vporton commented Jan 29, 2025

I've fixed a bug that caused it to compile the same canister twice. Now zondirectory2 compiles seamlessly.

@vporton
Copy link
Contributor Author

vporton commented Jan 30, 2025

After fixing some bugs, I successfully deployed my site in production using my modified DFX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant