-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: streamline dfx new output #4073
Merged
ericswanson-dfinity
merged 10 commits into
master
from
ens/sdk-1940-dfx-new-streamline-output
Jan 23, 2025
Merged
feat: streamline dfx new output #4073
ericswanson-dfinity
merged 10 commits into
master
from
ens/sdk-1940-dfx-new-streamline-output
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesi200
reviewed
Jan 22, 2025
lwshang
previously approved these changes
Jan 22, 2025
check project template compatibility before writing anything added some debug logs
lwshang
approved these changes
Jan 23, 2025
rikonor
pushed a commit
that referenced
this pull request
Feb 3, 2025
- add some spinners - add some debug logs - remove welcome message - check project template compatibility before writing anything Fixes: https://dfinity.atlassian.net/browse/SDK-1940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also fixes a bug: if passing
--no-frontend
and--extras frontend-tests
, would write the base files before erroring out.Before
After
After (verbose)
After (more verbose)
Fixes https://dfinity.atlassian.net/browse/SDK-1940
How Has This Been Tested?
Tested manually. Added an e2e test for
dfx new --no-frontend --extras frontend-tests
Checklist: