refactor: Prepare for auto-generation of extension.json #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchpop
changed the title
anchpop
force-pushed
the
@anchpop/auto-generate-extension-json-prep
branch
from
77b14c6 to
7fd6944
Compare
anchpop
force-pushed
the
@anchpop/auto-generate-extension-json-prep
branch
from
7fd6944 to
65afda3
Compare
anchpop
force-pushed
the
@anchpop/auto-generate-extension-json-prep
branch
from
65afda3 to
ecb327b
Compare
auto-merge was automatically disabled
July 1, 2024 21:09
Pull Request is not mergeable
ericswanson-dfinity
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, extension.json is always written by hand. Since the target type of extension.json is ExtensionManifest, in theory it could be automatically generated from the information by clap. But libraries importing ExtensionManifest are not able to actually do this because some fields are not
puband becauseExtensionManifestdoesn't implementSerialize. This PR fixes both of those issues