Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: document valid identity names #3747

Merged
merged 1 commit into from
May 8, 2024
Merged

chore: document valid identity names #3747

merged 1 commit into from
May 8, 2024

Conversation

sesi200
Copy link
Contributor

@sesi200 sesi200 commented May 8, 2024 •
edited by jira bot
Loading

Description

The dfx identity new help text and documentation don't state what a valid identity name looks like.

Fixes SDK-1481

How Has This Been Tested?

Not tested

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@sesi200 sesi200 requested review from chenyan-dfinity and a team as code owners May 8, 2024 08:21
@sesi200 sesi200 enabled auto-merge (squash) May 8, 2024 08:50
@sesi200 sesi200 merged commit 4e0df93 into master May 8, 2024
178 of 179 checks passed
@sesi200 sesi200 deleted the SDK-1481-clarify-what-identity-names-are-valid branch May 8, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericswanson-dfinity ericswanson-dfinity ericswanson-dfinity approved these changes

@chenyan-dfinity chenyan-dfinity Awaiting requested review from chenyan-dfinity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sesi200 @ericswanson-dfinity