feat: use cycles ledger in deposit-cycles #3626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
THLO
reviewed
Mar 1, 2024
| call_sender = &proxy_sender; | ||
| } | ||
| Err(err) => { | ||
| if CYCLES_LEDGER_ENABLED && matches!(err, crate::lib::identity::wallet::GetOrCreateWalletCanisterError::NoWalletConfigured { .. }) { |
There was a problem hiding this comment.
Why does the error handling of the get_or_create_wallet_canister depend on the flag CYCLES_LEDGER_ENABLED?
There was a problem hiding this comment.
Because until we enable the cycles ledger functionality we want to preserve the previous behavior of erroring out because no cycles wallet is configured. Once the cycles ledger is enabled we will just try to use the cycles in the cycles ledger
lwshang
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dfx canister deposit-cyclesnow is also capable of using cycles on the cycles ledger to top up a canister.The test
dfx/cycles-ledger/top-up and deposit-cyclespassed when the feature flag was turned on, see e.g. this run: macos, ubuntu. It is now disabled until the feature flag gets enabled (ETA ~1 month)Fixes SDK-1371
How Has This Been Tested?
added e2e
Checklist: