Closed
Conversation
this is the equivalent of what #303 did to `dfx`: When CBOR-encoding a canisterid for submission in a request, we need to make sure it is little endian. We do the change in ``` class CanisterIdEncoder implements CborEncoder<CanisterId> { … ``` where it belongs: As close to the HTTP interface we can. This means that once we migrate to https://github.com/dfinity-lab/dfinity/pull/2286 we will adjust this code to switch to CBOR blob, and the work-around can be dropped here. Note in the code about that. Also cleans up `fromText` to be more robust: It will _only_ accept `ic:` textual representation, and _always_ strip the checksum. With this, I can * build and install Linkedup * copy the `ic:` url printed by `dfx` upon installation * use that in the url (e.g. `http://127.0.0.1:8000/?canisterId=ic:72028DEDFB546FA89A`) * see it load the assets
Contributor
|
What is left do here? I.e. what doesn’t workon master (after #319 got merged)? |
Contributor
Author
|
Maybe not. This was created when I failed to properly build your fix. My matrix multiply example still doesn't work (canister id not found in client), but given that master works on both default app and linkedup, maybe it's just my javascript is bad. |
Contributor
|
I don't think this is needed anymore, as we don't use endianness anywhere. |
Contributor
|
Please re-open if you feel this should be updated and done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.