SDK-669 INF-808: Fix flakiness in integration tests#313
Merged
mergify[bot] merged 2 commits intomasterfrom Jan 15, 2020
Merged
Conversation
The cause for the issue was debuged last week: https://dfinity.atlassian.net/browse/INF-771 Master is red so often that we almost missed a security vulnerability notification, so I took a stab at fixing the flakiness.
eftychis
approved these changes
Jan 15, 2020
Contributor
eftychis
left a comment
eftychis
left a comment
There was a problem hiding this comment.
Thanks I started something similar on Monday trying to get it without temp files, but got hit down with ids.
eftychis
changed the title
dfinity-bot
added a commit
that referenced
this pull request
Nov 2, 2020
## Changelog for common: Branch: master Commits: [dfinity-lab/common@897d4674...cb233ae6](https://github.com/dfinity-lab/common/compare/897d4674debd73015bc0273bca2ac6cbb0943516...cb233ae68f2bbe8cae1a3c69a3c40d9971f715fe) * [`3d540fd5`](https://github.com/dfinity-lab/common/commit/3d540fd5fd430e9b3f9efbafeaa014101a9895b8) mk-jobset.nix: only have all-jobs on jobsets tracking master ([dfinity-lab/common#312](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/312)) * [`cb233ae6`](https://github.com/dfinity-lab/common/commit/cb233ae68f2bbe8cae1a3c69a3c40d9971f715fe) niv niv: update 9d35b9e4 -> 20c89927 ([dfinity-lab/common#313](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/313))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cause for the issue was debuged last week: https://dfinity.atlassian.net/browse/INF-771
Master is red so often that we almost missed a security vulnerability notification, so I took a stab at fixing the flakiness.