-
Notifications
You must be signed in to change notification settings - Fork 98
chore: update replica version to cbf9a3bb #2692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mergify
merged 6 commits into
master
from
chore-update-replica-cbf9a3bbd63f37f343f5ebc44e88eafff1481767
Oct 17, 2022
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
390cf20
chore: update replica version to cbf9a3bbd63f37f343f5ebc44e88eafff148…
bitdivine f8e8a42
Merge branch 'master' into chore-update-replica-cbf9a3bbd63f37f343f5e…
bitdivine 3e7b60a
Disable sns tests that are not used yet
bitdivine a9dd436
Disable sns tests that are not used yet
bitdivine dcc68ea
CHANGELOG++
bitdivine ec98708
Merge replica updates
bitdivine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,22 +65,19 @@ SNS_CONFIG_FILE_NAME="sns.yml" | |
| dfx start --clean --background --host 127.0.0.1:8080 | ||
| sleep 1 | ||
| dfx nns install | ||
| # There are no entries for "local" upstream yet, so we need a network mapping. | ||
| dfx nns import --network-mapping local=mainnet | ||
| # This canister ID is not included upstream .. yet. | ||
| jq '.canisters["nns-sns-wasm"].remote.id.local="qaa6y-5yaaa-aaaaa-aaafa-cai"' dfx.json | sponge dfx.json | ||
| ls candid | ||
| cat dfx.json | ||
| dfx nns import --network-mapping local | ||
| dfx nns import | ||
| dfx sns import | ||
| ls candid | ||
| cat dfx.json | ||
| # Deploy the SNS | ||
| install_asset sns/valid | ||
| dfx sns config validate | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. However a whitelist has been added so we cannot get past this next step: |
||
| dfx sns deploy | ||
| # The remaining steps don't work any more as a pre-launch whitelist has been added. | ||
| #dfx sns deploy | ||
| # SNS canister IDs should be saved | ||
| dfx canister id sns_governance | ||
| dfx canister id sns_index | ||
| dfx canister id sns_ledger | ||
| dfx canister id sns_root | ||
| dfx canister id sns_swap | ||
| #dfx canister id sns_governance | ||
| #dfx canister id sns_index | ||
| #dfx canister id sns_ledger | ||
| #dfx canister id sns_root | ||
| #dfx canister id sns_swap | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The local entries mentioned and patched on the left are now entered cleanly so we can remove the patchwork.