fix: Save SNS canister IDs#2610
Merged
bitdivine merged 9 commits intochore-update-replica-10c0341032ac00c9728ecefa1e82e919f0f09022from Oct 10, 2022
Merged
fix: Save SNS canister IDs#2610bitdivine merged 9 commits intochore-update-replica-10c0341032ac00c9728ecefa1e82e919f0f09022from
bitdivine merged 9 commits intochore-update-replica-10c0341032ac00c9728ecefa1e82e919f0f09022from
Conversation
…c00c9728ecefa1e82e919f0f09022' into test-sns-canisters-saved
6f2dc4c to
9a8de9c
Compare
1d8d4c7
into
chore-update-replica-10c0341032ac00c9728ecefa1e82e919f0f09022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses two problems with the call to
snsto create SNS canisters:snscommand line tool is not always able to locate the did file, so fails to parse thesns deployresponse.snscommand line tool saves canister ids incanister_ids.jsonbut this is incorrect when deploying tolocal. Given that the--networkflag is not supported, all deployments are tolocal, at least now.Changes
Use two new flags provided by the
snsbinary:--candidprovides the location of the candid file, so that the response is parsed reliably.--save-tospecifies to which canister_ids file to save the SNS canister IDs. This points to the file for local deployments and can be pointed at different locations once the--networkflag is supported.How Has This Been Tested?
This needs a more recent
snsbinary than the one currently in master, so this PR will fail in CI until we have upgraded. I believe the current protocol is to open a branch for an anticipated new blessed version of the ic, merge changes such as this into there, then merge that branch into master once the version has been blessed. We could bump just the sns binary; it is currently not used for anything other than this. Doing so would save a lot of time.I have tested locally by installing dfx with a matching sns thus:
Checklist:
This is a noop