refactor: Move replica URL functions into a module for reuse#2503
Merged
refactor: Move replica URL functions into a module for reuse#2503
Conversation
bitdivine
force-pushed
the
reuseable-replica-port
branch
2 times, most recently
from
b69294a to
0ac6950
Compare
bitdivine
force-pushed
the
reuseable-replica-port
branch
from
0ac6950 to
f65b8bd
Compare
bitdivine
changed the title
bitdivine
force-pushed
the
reuseable-replica-port
branch
from
d903c9f to
e1b7144
Compare
viviveevee
approved these changes
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The running replica port and url are generally useful information. Previously the code to get the URL was embedded in the network proxy code. This moves it out into a library for reuse.
How Has This Been Tested?
Existing tests should suffice. The behaviour is unchanged and there is no new code.
Checklist: