Skip to content

chore: update replica version to 83a49ca4#2495

Closed
dfinity-bot wants to merge 1 commit intomasterfrom
chore-update-replica-83a49ca4480448197e63e36a025709f5b13e3788
Closed

chore: update replica version to 83a49ca4#2495
dfinity-bot wants to merge 1 commit intomasterfrom
chore-update-replica-83a49ca4480448197e63e36a025709f5b13e3788

Conversation

@dfinity-bot
Copy link
Contributor

Suggested CHANGELOG.md changes

## Dependencies

### Replica

Updated replica to elected commit 83a49ca4480448197e63e36a025709f5b13e3788.
This incorporates the following executed proposals:


Previous replica version

6e86169e98904047833ba6133e5413d2758d90eb

Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bot trusts that bot

@bitdivine
Copy link
Contributor

Note: I didn't realize that the default commit chosen by the action was from two weeks ago, not head of master. It uses the last version used in production, as published on the IC dashboard. Unfortunately that is not recent enough to get an ic-nns-init that initializes sns canisters correctly.

At least the last action had the benefit of updating the tests to a more recent version of the IC! :-)

@smallstepman
Copy link
Contributor

smallstepman commented Aug 25, 2022

Correct. The main purpose of this workflow is to provide sdk codebase with the latest elected replica version, and not the latest overall commit (this is of course done for the sake of stability which I'd say is one of the main goals of sdk repo), however, as you discovered, you can select "custom" in a dropbox + provide any valid commit SHA from dfinity/ic and stuff will work™️
image

@smallstepman
Copy link
Contributor

However, while it's ok to merge unelected replica version to sdk's master branch, I don't think we'd be able to create the sdk release with such a replica version (just something to keep at the back of our heads cc: @ericswanson-dfinity)

@smallstepman
Copy link
Contributor

if you wish to experiment with different replica versions against your feature branch, you could as well try to use
image.
I haven't tried that myself yet but it should work.

that way you'll be able to:

  • skip PR approval requirement
  • skip CI checks (which may or may not be desirable for you (cc: @ericswanson-dfinity I think it would be a good idea to provide a way to run CI checks against manually selected branches/PR, e.g.
chore: update replica version to 83a49ca4 #2495
[dfinity-bot] wants to merge 1 commit into [CUSTOM_BRANCH] from [chore-update-replica-83a49ca4480448197e63e36a025709f5b13e3788]

)).

@bitdivine
Copy link
Contributor

Thank you for the info. I see there is a rc--2022-08-24_18-32. I just need to be patient. Not very good at that, I am.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, in general, we only merge elected versions of the replica into the master branch. But this branch can be used as a base for ongoing work, in the meantime.

@bitdivine
Copy link
Contributor

The latest version in production has been updated, so I've triggered the workflow to update that. Closing this PR. So long and thanks for all the tips. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments