Merged
Conversation
ghost
reviewed
Aug 19, 2022
ghost
suggested changes
Aug 19, 2022
commit ed42db1 Author: Adam Spofford <adam.spofford@dfinity.org> Date: Mon Aug 22 12:04:52 2022 -0400 It was right there the whole time commit 74d31f9 Author: Adam Spofford <adam.spofford@dfinity.org> Date: Mon Aug 22 11:13:26 2022 -0400 hash the domain separator commit e594b43 Author: Adam Spofford <adam.spofford@dfinity.org> Date: Fri Aug 19 17:11:58 2022 -0400 Verify cert
ghost
reviewed
Aug 22, 2022
ghost
approved these changes
Aug 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements SDK-483, SDK-484.
Testing will unfortunately not be possible, as even the patched CMC cannot create canisters. Manual testing was performed, and produced the wallet
tnof3-diaaa-aaaap-qappa-caifrom about 1.7 ICP.