fix: for release script calling dfx generate to incorrect dfx executable#2443
Merged
mergify[bot] merged 6 commits intomasterfrom Aug 16, 2022
Merged
fix: for release script calling dfx generate to incorrect dfx executable#2443mergify[bot] merged 6 commits intomasterfrom
mergify[bot] merged 6 commits intomasterfrom
Conversation
added 2 commits
August 12, 2022 14:18
This matches the step already documented in the release process notes.
Since package.json now specifies to call `dfx generate`, we need to alter the release script so that this calls the release candidate dfx executable rather than another one. To do this, the release script now prepends the target directory to the PATH, and calls dfx using that. This avoids errors like this during the release process: Creating canister hello_world_frontend... hello_world_frontend canister created with canister id: ryjl3-tyaaa-aaaaa-aaaba-cai Building canisters... Building frontend... WARN: Warning: The version of DFX used (0.9.1-303-g4e0b172d) is different than the version being run (0.11.0). This might happen because your dfx.json specifies an older version, or DFX_VERSION is set in your environment. We are forwarding the command line to the old version. To disable this warning, set the DFX_WARNING=-version_check environment variable. Building canisters before generate for Motoko
ghost
self-requested a review
as a 
lwshang
approved these changes
Aug 15, 2022
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since package.json now specifies to call
dfx generate, we need to alter the release script so that this calls the release candidate dfx executable rather than some other one. To do this, the release script now prepends the target directory to the PATH, and calls dfx using that.This avoids errors like this during the release process:
Also updated the allowed regex for release names for more arbitrary strings than just
alphaandbeta.How Has This Been Tested?