Skip to content

Rm invalid comma for valid manifest.json#244

Merged
hansl merged 1 commit intomasterfrom
eftychis-fix-manifest
Dec 9, 2019
Merged

Rm invalid comma for valid manifest.json#244
hansl merged 1 commit intomasterfrom
eftychis-fix-manifest

Conversation

@eftychis
Copy link
Contributor

@eftychis eftychis commented Dec 9, 2019

We have an invalid json.

@eftychis eftychis requested a review from a team as a code owner December 9, 2019 20:22
@hansl hansl merged commit f0c228d into master Dec 9, 2019
dfinity-bot added a commit that referenced this pull request Aug 31, 2020
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@01f876ed...2a0a8ef1](https://github.com/dfinity-lab/common/compare/01f876edfbafbaa2b4740489a3a179ebddda062e...2a0a8ef1f7591300ad6cfc807548376734660ace)

* [`8f122bb4`](https://github.com/dfinity-lab/common/commit/8f122bb4312313e8a5143d92e34f106c1c8405d9) Revert "Revert "[INF-1384] rustc: 1.43 => 1.45, add rust-analyzer" ([dfinity-lab/common⁠#244](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/244))" ([dfinity-lab/common⁠#245](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/245))
* [`5b875a02`](https://github.com/dfinity-lab/common/commit/5b875a0212f52e9372b166eafd3fecfec195af71) Add yotam to accounts
* [`3097a75b`](https://github.com/dfinity-lab/common/commit/3097a75b9bc7d7bc7c139d042bce7e7cc4d64a95) add bogdan to accounts
* [`8c1d0bf5`](https://github.com/dfinity-lab/common/commit/8c1d0bf508df2c253f18b5ce4588379bfffb9e80) add rahul to accounts
* [`ac2e4383`](https://github.com/dfinity-lab/common/commit/ac2e438342c614b91030607407ab15fadb0d872d) niv niv: update 89ae775e -> fad2a6cb
* [`f0a9530e`](https://github.com/dfinity-lab/common/commit/f0a9530eda23667d337a1ac501e0e6edb0ef20a7) INF-1483: Update niv-updater-action
* [`b079b6d5`](https://github.com/dfinity-lab/common/commit/b079b6d52ecef4a7930d9dad562a07e0f840f8ea) Revert "Revert "Revert "[INF-1384] rustc: 1.43 => 1.45, add rust-analyzer" ([dfinity-lab/common⁠#244](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/244))" ([dfinity-lab/common⁠#245](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/245))" ([dfinity-lab/common⁠#261](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/261))
* [`2a0a8ef1`](https://github.com/dfinity-lab/common/commit/2a0a8ef1f7591300ad6cfc807548376734660ace) INF-1486: Document how to perform a rustc upgrade
mergify bot pushed a commit that referenced this pull request Aug 31, 2020
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@01f876ed...2a0a8ef1](https://github.com/dfinity-lab/common/compare/01f876edfbafbaa2b4740489a3a179ebddda062e...2a0a8ef1f7591300ad6cfc807548376734660ace)

* [`8f122bb4`](https://github.com/dfinity-lab/common/commit/8f122bb4312313e8a5143d92e34f106c1c8405d9) Revert "Revert "[INF-1384] rustc: 1.43 => 1.45, add rust-analyzer" ([dfinity-lab/common⁠#244](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/244))" ([dfinity-lab/common⁠#245](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/245))
* [`5b875a02`](https://github.com/dfinity-lab/common/commit/5b875a0212f52e9372b166eafd3fecfec195af71) Add yotam to accounts
* [`3097a75b`](https://github.com/dfinity-lab/common/commit/3097a75b9bc7d7bc7c139d042bce7e7cc4d64a95) add bogdan to accounts
* [`8c1d0bf5`](https://github.com/dfinity-lab/common/commit/8c1d0bf508df2c253f18b5ce4588379bfffb9e80) add rahul to accounts
* [`ac2e4383`](https://github.com/dfinity-lab/common/commit/ac2e438342c614b91030607407ab15fadb0d872d) niv niv: update 89ae775e -> fad2a6cb
* [`f0a9530e`](https://github.com/dfinity-lab/common/commit/f0a9530eda23667d337a1ac501e0e6edb0ef20a7) INF-1483: Update niv-updater-action
* [`b079b6d5`](https://github.com/dfinity-lab/common/commit/b079b6d52ecef4a7930d9dad562a07e0f840f8ea) Revert "Revert "Revert "[INF-1384] rustc: 1.43 => 1.45, add rust-analyzer" ([dfinity-lab/common⁠#244](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/244))" ([dfinity-lab/common⁠#245](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/245))" ([dfinity-lab/common⁠#261](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/261))
* [`2a0a8ef1`](https://github.com/dfinity-lab/common/commit/2a0a8ef1f7591300ad6cfc807548376734660ace) INF-1486: Document how to perform a rustc upgrade


[INF-1384]: https://dfinity.atlassian.net/browse/INF-1384
[INF-1384]: https://dfinity.atlassian.net/browse/INF-1384
gobengo pushed a commit that referenced this pull request Sep 1, 2020
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@01f876ed...2a0a8ef1](https://github.com/dfinity-lab/common/compare/01f876edfbafbaa2b4740489a3a179ebddda062e...2a0a8ef1f7591300ad6cfc807548376734660ace)

* [`8f122bb4`](https://github.com/dfinity-lab/common/commit/8f122bb4312313e8a5143d92e34f106c1c8405d9) Revert "Revert "[INF-1384] rustc: 1.43 => 1.45, add rust-analyzer" ([dfinity-lab/common⁠#244](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/244))" ([dfinity-lab/common⁠#245](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/245))
* [`5b875a02`](https://github.com/dfinity-lab/common/commit/5b875a0212f52e9372b166eafd3fecfec195af71) Add yotam to accounts
* [`3097a75b`](https://github.com/dfinity-lab/common/commit/3097a75b9bc7d7bc7c139d042bce7e7cc4d64a95) add bogdan to accounts
* [`8c1d0bf5`](https://github.com/dfinity-lab/common/commit/8c1d0bf508df2c253f18b5ce4588379bfffb9e80) add rahul to accounts
* [`ac2e4383`](https://github.com/dfinity-lab/common/commit/ac2e438342c614b91030607407ab15fadb0d872d) niv niv: update 89ae775e -> fad2a6cb
* [`f0a9530e`](https://github.com/dfinity-lab/common/commit/f0a9530eda23667d337a1ac501e0e6edb0ef20a7) INF-1483: Update niv-updater-action
* [`b079b6d5`](https://github.com/dfinity-lab/common/commit/b079b6d52ecef4a7930d9dad562a07e0f840f8ea) Revert "Revert "Revert "[INF-1384] rustc: 1.43 => 1.45, add rust-analyzer" ([dfinity-lab/common⁠#244](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/244))" ([dfinity-lab/common⁠#245](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/245))" ([dfinity-lab/common⁠#261](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/261))
* [`2a0a8ef1`](https://github.com/dfinity-lab/common/commit/2a0a8ef1f7591300ad6cfc807548376734660ace) INF-1486: Document how to perform a rustc upgrade


[INF-1384]: https://dfinity.atlassian.net/browse/INF-1384
[INF-1384]: https://dfinity.atlassian.net/browse/INF-1384
@lwshang lwshang deleted the eftychis-fix-manifest branch July 29, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants