Merged
Conversation
ghost
approved these changes
Jul 15, 2022
ghost
mentioned this pull request
3 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 25, 2022
…uild step (#2373) # Description Adds a test for #2351, and updates the custom deserializer to use a default for the `build` field. There's no change to the changelog, because this is covered by an existing entry, in the current `UNRELEASED` section. # How Has This Been Tested? Updated an existing e2e test. # Checklist: - [x] The title of this PR complies with [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/). - [x] I have edited the CHANGELOG accordingly. - [x] I have made corresponding changes to the documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to 494c566, someone could leave off the
buildfield of the config for a custom canister and never receive an error about it if they never randfx build. This restores that behavior by making a missingbuildfield equivalent tobuild: [].