fix: improve responsiveness of greet method in Motoko project template#2345
Merged
smallstepman merged 5 commits intomasterfrom Aug 15, 2022
Merged
fix: improve responsiveness of greet method in Motoko project template#2345smallstepman merged 5 commits intomasterfrom
greet method in Motoko project template#2345smallstepman merged 5 commits intomasterfrom
Conversation
matthewhammer
changed the title
matthewhammer
changed the title
matthewhammer
changed the title
ggreif
approved these changes
Jul 14, 2022
ghost
previously requested changes
Jul 14, 2022
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Would you please add an entry to the changelog?
ghost
dismissed
their stale review
I'm on PTO next week, so don't want to prevent this from being merged.
ghost
approved these changes
Aug 15, 2022
smallstepman
changed the title
greet method in Motoko project template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
greetis marked as an update call, but it performs no state updates. It can be faster as a query call.