feat: bootstrap: look up replica/emulator port#2317
Merged
mergify[bot] merged 4 commits intomasterfrom Jul 6, 2022
Merged
Conversation
ghost
self-requested a review
as a
added 2 commits
July 5, 2022 17:53
…bootstrap-use-running-port
…bootstrap-use-running-port
viviveevee
approved these changes
Jul 6, 2022
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dfx replicawrites the replica port into one of two places. Makedfx bootstraplook up the replica port from there.This way, it won't be necessary to have a network entry in dfx.json. This will help with the upcoming system-wide dfx changes, because adding a network entry in dfx.json would alter the conditions of the test.
Fixes https://dfinity.atlassian.net/browse/SDK-511
How Has This Been Tested?
Covered by existing e2e tests
Checklist: