Skip to content

Comments

feat: Enable threshold ecdsa signature#2297

Merged
mergify[bot] merged 4 commits intomasterfrom
paulliu/enable-threshold-ecdsa-signature-feature-by-default
Jul 9, 2022
Merged

feat: Enable threshold ecdsa signature#2297
mergify[bot] merged 4 commits intomasterfrom
paulliu/enable-threshold-ecdsa-signature-feature-by-default

Conversation

@ninegua
Copy link
Member

@ninegua ninegua commented Jun 27, 2022

Turn on ECDSA signature signing by default with a test key named "Secp256k1:dfx_test_key".

Description

This enables developers to use threshold ECDSA system APIs when deploying code in a local dev environment.

How Has This Been Tested?

It has been tested manually to be working.

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • I have made corresponding changes to the documentation.

@ninegua ninegua force-pushed the paulliu/enable-threshold-ecdsa-signature-feature-by-default branch 2 times, most recently from 7be4659 to a6b0e66 Compare June 27, 2022 17:46
@ninegua ninegua force-pushed the paulliu/enable-threshold-ecdsa-signature-feature-by-default branch from a6b0e66 to a5d6eb0 Compare July 6, 2022 05:14
@ninegua ninegua marked this pull request as ready for review July 7, 2022 15:40
@ninegua ninegua requested a review from a team as a code owner July 7, 2022 15:40
@ninegua
Copy link
Member Author

ninegua commented Jul 7, 2022

with a caveat that we must wait for a full DKG interfaceinterval (500 blocks in the default setting) before starting to use the key.

This will be fully addressed in https://gitlab.com/dfinity-lab/public/ic/-/merge_requests/6069. So the situation now is:

  1. With this PR, users will be able to start using ECDSA key with id Secp256k1:dfx_test_key in dfx, but need to wait until a fresh dfx start has gone through the first 1000 rounds (no good indicator to find out, but roughly 1000 seconds).
  2. Once MR 6069 is merged and dfx gets the the replica from a release afterwards, users will be able to use the key immediately after dfx start.

@ghost ghost added the automerge-squash label Jul 9, 2022
@mergify mergify bot merged commit 739ba4f into master Jul 9, 2022
@mergify mergify bot deleted the paulliu/enable-threshold-ecdsa-signature-feature-by-default branch July 9, 2022 04:44
@mergify mergify bot removed the automerge-squash label Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant