chore: Remove extra field from config#2281
Merged
mergify[bot] merged 29 commits intomasterfrom Jul 12, 2022
Merged
Conversation
ghost
previously requested changes
Jun 20, 2022
viviveevee
reviewed
Jun 21, 2022
ghost
dismissed
their 
…into spofford/full-serde
This reverts commit f358155.
ghost
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it makes everything easier, I have also taken the opportunity to replace the truly ancient crate humanize_rs with humantime and byte-unit, replace a few more Strings with PathBufs, and remove some of the more object-oriented design in the canister info/builder system.