fix: dfx ping uses the anonymous identity and does not require dfx.json#2263
Merged
mergify[bot] merged 3 commits intomasterfrom Jun 15, 2022
Merged
Conversation
added 2 commits
June 14, 2022 13:52
ghost
self-requested a review
as a 
viviveevee
approved these changes
Jun 15, 2022
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
pingcommand uses the default identity, which means it has side effects: it creates the default identity if it does not exist.To work around this, the e2e tests run ping with a throw-away config root, in order to discard the newly created identity. However, with the upcoming system-wide dfx changes, dfx will sometimes use configuration within the config root to find the local server.
We can avoid this altogether by making ping use the anonymous identity.
Fixes https://dfinity.atlassian.net/browse/SDK-505
How Has This Been Tested?
Updated e2e tests.
Checklist: