Skip to content

refactor: Environment.get_network_descriptor is unreachable #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 1 commit into from
Closed

refactor: Environment.get_network_descriptor is unreachable #2222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/dfx/src/lib/environment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,9 @@ impl Environment for EnvironmentImpl {
}

fn get_network_descriptor(&self) -> Option<&NetworkDescriptor> {
// create an AgentEnvironment explicitly, in order to specify network and agent.
// See install, build for examples.
None
// It's not valid to call get_network_descriptor on an EnvironmentImpl.
// All of the places that call this have an AgentEnvironment anyway.
unreachable!("NetworkDescriptor only available from an AgentEnvironment");
}

fn get_logger(&self) -> &slog::Logger {
Expand Down