refactor: Environment.get_network_descriptor() returns a ref, not an option#2220
Merged
mergify[bot] merged 4 commits intomasterfrom May 23, 2022
Merged
Conversation
…tion zthis eliminates a bunch of unwrap() and expect() calls that can never trigger anyway, because the Environment in question is always an AgentEnvironment anyway.
ghost
self-requested a review
as a 
viviveevee
approved these changes
May 21, 2022
ghost
added
the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This eliminates a bunch of unwrap() and expect() calls that can never trigger, because the Environment in question is always an AgentEnvironment anyway. In practice, Environment::get_network_descriptor can never be called, so it now calls
unreachable!().This is preliminary work for system-wide dfx start
How Has This Been Tested?
e2e tests will cover it
Checklist: