Merged
Conversation
added 6 commits
May 12, 2022 12:38
dynamic-link the linux binary, but static-link openssl
lwshang
approved these changes
May 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Build the Linux binary dynamically, as was done in dfx 0.9.3 and earlier, in order to avoid the following error when trying to use an HSM:
Other changes to the workflow:
Fixes https://dfinity.atlassian.net/browse/SDK-495
How Has This Been Tested?
Tested manually with an HSM. Here's a sample release: https://github.com/dfinity/sdk/releases/tag/0.10.1-hsm.1
Checklist: