Skip to content

fix: HSM support on Linux build#2202

Merged
mergify[bot] merged 8 commits intomasterfrom
ericswanson/sdk-496-linux-hsm
May 14, 2022
Merged

fix: HSM support on Linux build#2202
mergify[bot] merged 8 commits intomasterfrom
ericswanson/sdk-496-linux-hsm

Conversation

@ghost
Copy link

@ghost ghost commented May 13, 2022

Description

Build the Linux binary dynamically, as was done in dfx 0.9.3 and earlier, in order to avoid the following error when trying to use an HSM:

Error: IO: Dynamic loading not supported

Other changes to the workflow:

  • manually build a static-linked openssl for the linux build
  • allow words other than "beta" in the tag name
  • removed the "test-#.#.#-*" tag allowance, because those wouldn't be a valid semver (and dfx would panic)
  • verify the list of referenced dynamic libraries, to avoid post-release surprises.

Fixes https://dfinity.atlassian.net/browse/SDK-495

How Has This Been Tested?

Tested manually with an HSM. Here's a sample release: https://github.com/dfinity/sdk/releases/tag/0.10.1-hsm.1

Checklist:

  • The title of this PR complies with Conventional Commits.
  • I have edited the CHANGELOG accordingly.
  • (n/a) I have made corresponding changes to the documentation.

@ghost ghost self-requested a review as a code owner May 13, 2022 19:29
@ghost ghost added the automerge-squash label May 13, 2022
@mergify mergify bot merged commit 5f6001f into master May 14, 2022
@mergify mergify bot deleted the ericswanson/sdk-496-linux-hsm branch May 14, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant