Skip to content

Comments

chore: use blessed replica to avoid changing sha256#1942

Merged
mergify[bot] merged 21 commits intomasterfrom
lint-broken
Dec 1, 2021
Merged

chore: use blessed replica to avoid changing sha256#1942
mergify[bot] merged 21 commits intomasterfrom
lint-broken

Conversation

@ghost
Copy link

@ghost ghost commented Nov 30, 2021

There were multiple versions of the replica and ic-starter tarballs at the old URLs. The tarballs with path including /blessed/ did not change.

Also:

  • disable failfast for cargo build and lint steps, since it's useful to see if a failure happened on both macos and ubuntu
  • run scripts/prepare-dfx-assets.sh as a separate workflow, since other workflows run much faster by caching its output, meaning it wasn't being tested on every run.
  • disable certificate.bash e2e test on linux because over the weekend, the pyparsing module on ubuntu-latest became incompatibility with mitmproxy there.

@ghost ghost changed the title chore: fix lint, cargo build CI steps failing chore: use blessed replica to avoid changing sha256 Nov 30, 2021
@ghost ghost marked this pull request as ready for review November 30, 2021 20:27
@ghost ghost added the automerge-squash label Dec 1, 2021
@mergify mergify bot merged commit 8fdfe2d into master Dec 1, 2021
@mergify mergify bot deleted the lint-broken branch December 1, 2021 19:07
@mergify mergify bot removed the automerge-squash label Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant