You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should we only set it if RUST_MIN_STACK is not already set in the environment? (of course dfx it itself a rust application, so would be using the same value from the same environment variable)
Should we add a new command-line argument to dfx start? (which would apply only when using the replica, not --emulator)
I think we have to go with a hard coded value, at least for now, just because there's no easy way to get the value that's used in the mainnet. That value is stored in ic-os/guestos/rootfs/etc/systemd/system/ic-replica.service (in the main ic repo) and already has a comment that the nix environment needs to be updated when the value changes. So we could add an additional comment about dfx needing to be updated.
I'm not sure what we want to do if the user has set the RUST_MIN_STACK themselves. We're only changing the environment only for the replica process, so all other running rust code will have the stack size they've set and this seems ok to me.
I don't have anything against an additional argument, but I'm not sure if anyone would actually want to use it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For discussion.
dfx start? (which would apply only when using the replica, not--emulator)