SDK-643 Update new project files for JS user library#190
Closed
SDK-643 Update new project files for JS user library#190
Conversation
Ported from #56. Try babel-loader next. See https://github.com/microsoft/TypeScript-Babel-Starter
This reverts commit eec6a2d.
…to paulyoung/js-user-lib-example
Now that dfx generates canister IDs as unsigned 64-bit integers (little endian) we need to make sure we can handle that in JavaScript. At present, the HTTP handler of the client rejects submit calls with a HTTP status code of 422, and the message "Could not parse body: invalid type: byte array, expected u64" despite attempting to send the canister_id field as a uint64 little endian typed array per the CBOR spec.
Since canister.js has no impact on invoking executables.
This reverts commit dc2416f.
hansl
approved these changes
Nov 21, 2019
Contributor
Author
|
Changing the base branch confused things here. Will open this again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This currently doesn't work because the default
serve_rootindfx.jsondefaults tosrc/hello/public, which means we can’t importcanisters/hello/main.jswith a relative path.