fix: Avoid proxy server hang on Linux by setting connection limit to 1#1784
Merged
mergify[bot] merged 2 commits intomasterfrom Aug 16, 2021
Merged
fix: Avoid proxy server hang on Linux by setting connection limit to 1#1784mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
ghost
changed the title
ghost
approved these changes
Aug 12, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Just for posterity: this webserver is only used to serve candid data when running dfx locally. So this change should be fine!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is essentially the same fix as in #1247.
We are still seeing this bug https://forum.dfinity.org/t/multiple-calls-queries-to-canister-blocks-them-all-from-sending-back-the-response/6406.
I believe by default there are 4 worker threads so concurrent connections are still possible. Unless we have strong evidence that this kills performance, I think it is better to unblock our users before we find a permanent solution.