chore: update agent-rs for candid 0.7.1 and ic-utils 0.2.0#1736
Merged
mergify[bot] merged 13 commits intomasterfrom Jul 6, 2021
Merged
chore: update agent-rs for candid 0.7.1 and ic-utils 0.2.0#1736mergify[bot] merged 13 commits intomasterfrom
mergify[bot] merged 13 commits intomasterfrom
Conversation
ghost
mentioned this pull request
added 12 commits
July 1, 2021 14:20
jwiegley
approved these changes
Jul 6, 2021
ghost
mentioned this pull request
mergify bot
pushed a commit
that referenced
this pull request
Jul 7, 2021
I missed these in [yesterday's PR](#1736) that updated agent-rs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This required a fix to agent-rs, because the hack we were using to get something like generic types no longer works with Candid 0.7.1: dfinity/agent-rs@c6543eb
Also, some candid text output formats changed, requiring changes to some e2e tests.