Conversation
ghost
suggested changes
Apr 29, 2021
Co-authored-by: Eric Swanson <64809312+ericswanson-dfinity@users.noreply.github.com>
ghost
reviewed
Apr 30, 2021
Comment on lines
+58
to
+75
| let controller = if let Some(controller) = opts.controller.clone() { | ||
| match CanisterId::from_text(controller.clone()) { | ||
| Ok(principal) => Some(principal), | ||
| Err(_) => { | ||
| let current_id = env.get_selected_identity().unwrap(); | ||
| if current_id == &controller { | ||
| Some(env.get_selected_identity_principal().unwrap()) | ||
| } else { | ||
| let identity_name = &controller; | ||
| let sender = IdentityManager::new(env)? | ||
| .instantiate_identity_from_name(&identity_name.clone())?; | ||
| Some(sender.sender().map_err(|err| anyhow!(err))?) | ||
| } | ||
| } | ||
| } | ||
| } else { | ||
| None | ||
| }; |
There was a problem hiding this comment.
Not blocking: this calculation for controller looks identical to code in create.rs.
ghost
approved these changes
Apr 30, 2021
dfinity-bot
added a commit
that referenced
this pull request
Mar 12, 2023
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@292b3a84...fa80f680](rustsec/advisory-db@292b3a8...fa80f68) * [`1d79443a`](rustsec/advisory-db@1d79443) Add unmaintained advisory for nphysics ([RustSec/advisory-db#1624](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1624)) * [`bb831bb8`](rustsec/advisory-db@bb831bb) Assigned RUSTSEC-2021-0148 to nphysics3d, RUSTSEC-2021-0149 to nphysics2d ([RustSec/advisory-db#1636](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1636)) * [`220fa871`](rustsec/advisory-db@220fa87) Add unmaintained advisory for ncollide ([RustSec/advisory-db#1623](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1623)) * [`ffe539ba`](rustsec/advisory-db@ffe539b) Assigned RUSTSEC-2021-0150 to ncollide3d, RUSTSEC-2021-0151 to ncollide2d ([RustSec/advisory-db#1637](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1637)) * [`84b7ddd2`](rustsec/advisory-db@84b7ddd) `out_reference::Out::from_raw` should be `unsafe` ([RustSec/advisory-db#1627](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1627)) * [`eab0949b`](rustsec/advisory-db@eab0949) Assigned RUSTSEC-2021-0152 to out-reference ([RustSec/advisory-db#1638](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1638)) * [`6fb0acde`](rustsec/advisory-db@6fb0acd) Add unmaintained advisory for mach ([RustSec/advisory-db#1616](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1616)) * [`d1e7c68b`](rustsec/advisory-db@d1e7c68) Assigned RUSTSEC-2020-0168 to mach ([RustSec/advisory-db#1639](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1639)) * [`4bb7a939`](rustsec/advisory-db@4bb7a93) Add boxfnonce informational advisory ([RustSec/advisory-db#1609](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1609)) * [`10278a15`](rustsec/advisory-db@10278a1) Assigned RUSTSEC-2019-0040 to boxfnonce ([RustSec/advisory-db#1640](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1640)) * [`2284b69d`](rustsec/advisory-db@2284b69) Add advisory encoding ([RustSec/advisory-db#1608](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1608)) * [`fa80f680`](rustsec/advisory-db@fa80f68) Assigned RUSTSEC-2021-0153 to encoding ([RustSec/advisory-db#1641](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1641))
mergify bot
pushed a commit
that referenced
this pull request
Mar 12, 2023
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@292b3a84...fa80f680](rustsec/advisory-db@292b3a8...fa80f68) * [`1d79443a`](rustsec/advisory-db@1d79443) Add unmaintained advisory for nphysics ([RustSec/advisory-db#1624](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1624)) * [`bb831bb8`](rustsec/advisory-db@bb831bb) Assigned RUSTSEC-2021-0148 to nphysics3d, RUSTSEC-2021-0149 to nphysics2d ([RustSec/advisory-db#1636](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1636)) * [`220fa871`](rustsec/advisory-db@220fa87) Add unmaintained advisory for ncollide ([RustSec/advisory-db#1623](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1623)) * [`ffe539ba`](rustsec/advisory-db@ffe539b) Assigned RUSTSEC-2021-0150 to ncollide3d, RUSTSEC-2021-0151 to ncollide2d ([RustSec/advisory-db#1637](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1637)) * [`84b7ddd2`](rustsec/advisory-db@84b7ddd) `out_reference::Out::from_raw` should be `unsafe` ([RustSec/advisory-db#1627](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1627)) * [`eab0949b`](rustsec/advisory-db@eab0949) Assigned RUSTSEC-2021-0152 to out-reference ([RustSec/advisory-db#1638](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1638)) * [`6fb0acde`](rustsec/advisory-db@6fb0acd) Add unmaintained advisory for mach ([RustSec/advisory-db#1616](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1616)) * [`d1e7c68b`](rustsec/advisory-db@d1e7c68) Assigned RUSTSEC-2020-0168 to mach ([RustSec/advisory-db#1639](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1639)) * [`4bb7a939`](rustsec/advisory-db@4bb7a93) Add boxfnonce informational advisory ([RustSec/advisory-db#1609](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1609)) * [`10278a15`](rustsec/advisory-db@10278a1) Assigned RUSTSEC-2019-0040 to boxfnonce ([RustSec/advisory-db#1640](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1640)) * [`2284b69d`](rustsec/advisory-db@2284b69) Add advisory encoding ([RustSec/advisory-db#1608](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1608)) * [`fa80f680`](rustsec/advisory-db@fa80f68) Assigned RUSTSEC-2021-0153 to encoding ([RustSec/advisory-db#1641](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1641))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update to dfinity/cycles-wallet@b5e38e1