feat: compress some content types#1595
Merged
mergify[bot] merged 13 commits intomasterfrom Apr 15, 2021
Merged
Conversation
added 12 commits
April 13, 2021 12:11
…e ContentEncoder::Identity
…press-some-content-types
hansl
reviewed
Apr 15, 2021
Comment on lines
445
to
447
| let k = Text.map(header.0, Prim.charToUpper); | ||
| let v = header.1; | ||
| if (k == "ACCEPT-ENCODING") { |
Contributor
There was a problem hiding this comment.
Can you use caseInsentiveCharCompare too on the checking for header? Not blocking, but I think it might improve readability;
Suggested change
| let k = Text.map(header.0, Prim.charToUpper); | |
| let v = header.1; | |
| if (k == "ACCEPT-ENCODING") { | |
| if (Text.compareWith(header.0, "Accept-Encoding", caseInsensitiveCharCompare)) { | |
| let v = header.1; |
Author
There was a problem hiding this comment.
I meant to remove caseInsensitiveTextEqual or at least leave a comment about it, because Text.compareWith(a,b,cmp) currently has a bug where it ignores the cmp parameter and instead always uses Char.compare
hansl
approved these changes
Apr 15, 2021
Contributor
hansl
left a comment
There was a problem hiding this comment.
LGTM. One non blocking comment that I'll leave to you.
dfinity-bot
added a commit
that referenced
this pull request
Mar 4, 2023
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@b485cf4d...8124c2ef](rustsec/advisory-db@b485cf4...8124c2e) * [`516ebee1`](rustsec/advisory-db@516ebee) Add advisory for pnet_packet ([RustSec/advisory-db#1595](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1595)) * [`988dc5fe`](rustsec/advisory-db@988dc5f) Fix some typos ([RustSec/advisory-db#1593](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1593)) * [`b83953fd`](rustsec/advisory-db@b83953f) Assigned RUSTSEC-2020-0167 to pnet_packet ([RustSec/advisory-db#1596](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1596)) * [`8dcbf290`](rustsec/advisory-db@8dcbf29) Better docs ([RustSec/advisory-db#1598](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1598)) * [`c536da77`](rustsec/advisory-db@c536da7) Update RUSTSEC-2020-0097.md ([RustSec/advisory-db#1600](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1600)) * [`90f7279a`](rustsec/advisory-db@90f7279) Add soundness advisory for cortex-m-rt ([RustSec/advisory-db#1601](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1601)) * [`19425285`](rustsec/advisory-db@1942528) Assigned RUSTSEC-2023-0014 to cortex-m-rt ([RustSec/advisory-db#1606](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1606)) * [`1a941a3d`](rustsec/advisory-db@1a941a3) Add sqlite advisory ([RustSec/advisory-db#1599](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1599)) * [`0e63414b`](rustsec/advisory-db@0e63414) Assigned RUSTSEC-2022-0090 to libsqlite3-sys ([RustSec/advisory-db#1607](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1607)) * [`6e74bc0d`](rustsec/advisory-db@6e74bc0) Add ascii advisory ([RustSec/advisory-db#1618](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1618)) * [`eadc6fea`](rustsec/advisory-db@eadc6fe) Add advisory Tauri filesystem scope bypass ([RustSec/advisory-db#1571](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1571)) * [`bf247555`](rustsec/advisory-db@bf24755) Assigned RUSTSEC-2023-0015 to ascii ([RustSec/advisory-db#1619](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1619)) * [`81e6e5a8`](rustsec/advisory-db@81e6e5a) Assigned RUSTSEC-2022-0091 to tauri ([RustSec/advisory-db#1621](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1621)) * [`6761c690`](rustsec/advisory-db@6761c69) Add informational advisory for partial_sort out-of-bounds read ([RustSec/advisory-db#1617](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1617)) * [`9a5b1008`](rustsec/advisory-db@9a5b100) Assigned RUSTSEC-2023-0016 to partial_sort ([RustSec/advisory-db#1622](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1622)) * [`94f44e82`](rustsec/advisory-db@94f44e8) `maligned::align_first` causes incorrect deallocation ([RustSec/advisory-db#1625](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1625)) * [`8124c2ef`](rustsec/advisory-db@8124c2e) Assigned RUSTSEC-2023-0017 to maligned ([RustSec/advisory-db#1626](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1626))
mergify bot
pushed a commit
that referenced
this pull request
Mar 6, 2023
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@b485cf4d...8124c2ef](rustsec/advisory-db@b485cf4...8124c2e) * [`516ebee1`](rustsec/advisory-db@516ebee) Add advisory for pnet_packet ([RustSec/advisory-db#1595](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1595)) * [`988dc5fe`](rustsec/advisory-db@988dc5f) Fix some typos ([RustSec/advisory-db#1593](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1593)) * [`b83953fd`](rustsec/advisory-db@b83953f) Assigned RUSTSEC-2020-0167 to pnet_packet ([RustSec/advisory-db#1596](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1596)) * [`8dcbf290`](rustsec/advisory-db@8dcbf29) Better docs ([RustSec/advisory-db#1598](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1598)) * [`c536da77`](rustsec/advisory-db@c536da7) Update RUSTSEC-2020-0097.md ([RustSec/advisory-db#1600](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1600)) * [`90f7279a`](rustsec/advisory-db@90f7279) Add soundness advisory for cortex-m-rt ([RustSec/advisory-db#1601](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1601)) * [`19425285`](rustsec/advisory-db@1942528) Assigned RUSTSEC-2023-0014 to cortex-m-rt ([RustSec/advisory-db#1606](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1606)) * [`1a941a3d`](rustsec/advisory-db@1a941a3) Add sqlite advisory ([RustSec/advisory-db#1599](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1599)) * [`0e63414b`](rustsec/advisory-db@0e63414) Assigned RUSTSEC-2022-0090 to libsqlite3-sys ([RustSec/advisory-db#1607](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1607)) * [`6e74bc0d`](rustsec/advisory-db@6e74bc0) Add ascii advisory ([RustSec/advisory-db#1618](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1618)) * [`eadc6fea`](rustsec/advisory-db@eadc6fe) Add advisory Tauri filesystem scope bypass ([RustSec/advisory-db#1571](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1571)) * [`bf247555`](rustsec/advisory-db@bf24755) Assigned RUSTSEC-2023-0015 to ascii ([RustSec/advisory-db#1619](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1619)) * [`81e6e5a8`](rustsec/advisory-db@81e6e5a) Assigned RUSTSEC-2022-0091 to tauri ([RustSec/advisory-db#1621](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1621)) * [`6761c690`](rustsec/advisory-db@6761c69) Add informational advisory for partial_sort out-of-bounds read ([RustSec/advisory-db#1617](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1617)) * [`9a5b1008`](rustsec/advisory-db@9a5b100) Assigned RUSTSEC-2023-0016 to partial_sort ([RustSec/advisory-db#1622](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1622)) * [`94f44e82`](rustsec/advisory-db@94f44e8) `maligned::align_first` causes incorrect deallocation ([RustSec/advisory-db#1625](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1625)) * [`8124c2ef`](rustsec/advisory-db@8124c2e) Assigned RUSTSEC-2023-0017 to maligned ([RustSec/advisory-db#1626](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1626))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store
gzipcontent encodings of assets with media types, if the compressed encoding is smaller than the source contents:text/**/javascript*/htmlImplements https://github.com/dfinity/dx-triage/issues/117