Merged
Conversation
Ported from #56. Try babel-loader next. See https://github.com/microsoft/TypeScript-Babel-Starter
This reverts commit eec6a2d.
paulyoung
changed the title
hansl
approved these changes
Nov 20, 2019
dfinity-bot
added a commit
that referenced
this pull request
Jul 9, 2021
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@cbeaf18e...4792a373](rustsec/advisory-db@cbeaf18...4792a37) * [`1889bffd`](rustsec/advisory-db@1889bff) prost-types: Timestamp conversion overflow ([RustSec/advisory-db#954](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/954)) * [`76294321`](rustsec/advisory-db@7629432) Assigned RUSTSEC-2021-0073 to prost-types ([RustSec/advisory-db#955](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/955)) * [`a9c31a6e`](rustsec/advisory-db@a9c31a6) Hotfix [RustSec/advisory-db#957](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/957) until we figure out what to do with it ([RustSec/advisory-db#958](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/958)) * [`3533e434`](rustsec/advisory-db@3533e43) Add rust-ammonia/ammonia[RustSec/advisory-db#142](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/142) ([RustSec/advisory-db#956](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/956)) * [`2d60adf5`](rustsec/advisory-db@2d60adf) Assigned RUSTSEC-2021-0074 to ammonia ([RustSec/advisory-db#959](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/959)) * [`730c1e81`](rustsec/advisory-db@730c1e8) Revert "Hotfix [RustSec/advisory-db#957](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/957) until we figure out what to do with it ([RustSec/advisory-db#958](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/958))" ([RustSec/advisory-db#960](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/960)) * [`674daf6f`](rustsec/advisory-db@674daf6) `ark_r1cs_std::mul_by_inverse` generated unsound constraints in versions below `0.3.1` ([RustSec/advisory-db#961](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/961)) * [`4792a373`](rustsec/advisory-db@4792a37) Assigned RUSTSEC-2021-0075 to ark-r1cs-std ([RustSec/advisory-db#962](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/962))
mergify bot
pushed a commit
that referenced
this pull request
Jul 21, 2021
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@cbeaf18e...4792a373](rustsec/advisory-db@cbeaf18...4792a37) * [`1889bffd`](rustsec/advisory-db@1889bff) prost-types: Timestamp conversion overflow ([RustSec/advisory-db#954](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/954)) * [`76294321`](rustsec/advisory-db@7629432) Assigned RUSTSEC-2021-0073 to prost-types ([RustSec/advisory-db#955](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/955)) * [`a9c31a6e`](rustsec/advisory-db@a9c31a6) Hotfix [RustSec/advisory-db#957](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/957) until we figure out what to do with it ([RustSec/advisory-db#958](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/958)) * [`3533e434`](rustsec/advisory-db@3533e43) Add rust-ammonia/ammonia[RustSec/advisory-db#142](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/142) ([RustSec/advisory-db#956](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/956)) * [`2d60adf5`](rustsec/advisory-db@2d60adf) Assigned RUSTSEC-2021-0074 to ammonia ([RustSec/advisory-db#959](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/959)) * [`730c1e81`](rustsec/advisory-db@730c1e8) Revert "Hotfix [RustSec/advisory-db#957](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/957) until we figure out what to do with it ([RustSec/advisory-db#958](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/958))" ([RustSec/advisory-db#960](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/960)) * [`674daf6f`](rustsec/advisory-db@674daf6) `ark_r1cs_std::mul_by_inverse` generated unsound constraints in versions below `0.3.1` ([RustSec/advisory-db#961](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/961)) * [`4792a373`](rustsec/advisory-db@4792a37) Assigned RUSTSEC-2021-0075 to ark-r1cs-std ([RustSec/advisory-db#962](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/962))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from #56. The second commit is new, and uses
babel-loaderas in https://github.com/microsoft/TypeScript-Babel-Starter.As far as I can tell, the trade off there is some extra webpack configuration and a dependency, for not creating intermediate files when bundling. However, I'd prefer not to have more that one way of compiling TypeScript, and the npm scripts seem useful, so I'm thinking we should revert that and not use
babel-loader.I'm creating a bundle for both browsers and Node.js. The latter was primarily motivated by the Motoko test suite relying on the JS user library to verify that the IDL works correctly. I'll update Motoko to use this instead of the branch used in #56.