feat: add ic-ref support to dfx replica command#1349
Merged
p-shahi merged 1 commit intojoachim/start-emulatorfrom Jan 30, 2021
Merged
feat: add ic-ref support to dfx replica command#1349p-shahi merged 1 commit intojoachim/start-emulatorfrom
p-shahi merged 1 commit intojoachim/start-emulatorfrom
Conversation
Contributor
Author
|
existing test passed https://hydra.dfinity.systems/jobset/dfinity-ci-build/sdk.pr-1349 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--emulatorflag to thedfx replicacommandFixes an inconsistency where
dfx replicawas writing the replica port to.dfx/config/port.txt. Now writes to.dfx/replica-configuration/replica-1.port(same asdfx start) and updatessignals.bashto reflect this.Moves some common actor start logic out of
commands/replica.rsandcommands/start.rstoactors/mod.rsTodo:
add ic-ref variant in
signals.bashtestrefactor common logic in
dfx bootstrapanddfx starttoactors/mod.rs