Skip to content

feat: add ic-ref support to dfx replica command#1349

Merged
p-shahi merged 1 commit intojoachim/start-emulatorfrom
pshahi/start-emulator-updates
Jan 30, 2021
Merged

feat: add ic-ref support to dfx replica command#1349
p-shahi merged 1 commit intojoachim/start-emulatorfrom
pshahi/start-emulator-updates

Conversation

@p-shahi
Copy link
Contributor

@p-shahi p-shahi commented Jan 30, 2021

Adds --emulator flag to the dfx replica command
Fixes an inconsistency where dfx replica was writing the replica port to .dfx/config/port.txt. Now writes to .dfx/replica-configuration/replica-1.port (same as dfx start) and updates signals.bash to reflect this.
Moves some common actor start logic out of commands/replica.rs and commands/start.rs to actors/mod.rs

Todo:
add ic-ref variant in signals.bash test
refactor common logic in dfx bootstrap and dfx start to actors/mod.rs

@p-shahi
Copy link
Contributor Author

p-shahi commented Jan 30, 2021

@p-shahi p-shahi merged commit 890155e into joachim/start-emulator Jan 30, 2021
@p-shahi p-shahi deleted the pshahi/start-emulator-updates branch January 30, 2021 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant