Skip to content

fix: address panic in dfx replica command #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 5 commits into from
Jan 29, 2021
Merged

fix: address panic in dfx replica command #1338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69af33d
fix: The dfx replica command panics because it tries to write the rep…
Jan 27, 2021
d803835
suddenly this file does not exist?
Jan 27, 2021
653de61
Merge branch 'master' into pshahi/fix-replica-command-panic
p-shahi Jan 29, 2021
638d008
fix assertions
Jan 29, 2021
9a74f1e
Merge branch 'master' into pshahi/fix-replica-command-panic
p-shahi Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/utils/assertions.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ assert_process_exits() {
# Asserts that `dfx start` and `replica` are no longer running
assert_no_dfx_start_or_replica_processes() {
! ( ps | grep "[/[:space:]]dfx start" )
! ( ps | cat .dfx/replica-configuration/replica-pid )
! ( kill -0 $(cat .dfx/replica-configuration/replica-pid) 2>/dev/null )
}

assert_file_eventually_exists() {
Expand Down
5 changes: 4 additions & 1 deletion src/dfx/src/commands/replica.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,16 @@ pub fn exec(env: &dyn Environment, opts: ReplicaOpts) -> DfxResult {
})
.start();

let replica_configuration_dir = env.get_temp_dir().join("replica-configuration");
std::fs::create_dir_all(&replica_configuration_dir)?;

let _replica_addr = actors::replica::Replica::new(actors::replica::Config {
ic_starter_path: ic_starter_pathbuf,
replica_config: config,
replica_path: replica_pathbuf,
shutdown_controller,
logger: Some(env.get_logger().clone()),
replica_configuration_dir: env.get_temp_dir().join("replica-configuration"),
replica_configuration_dir,
})
.start();

Expand Down