Fail if we do fail with su in the install script#113
Merged
1 commit merged intomasterfrom Oct 30, 2019
Merged
Conversation
Our only fallback was sudo, but we did not have a fail backup.
eftychis
force-pushed
the
eftychis-fail-su-install
branch
from
f3038e3 to
c28f686
Compare
ghost
approved these changes
Oct 30, 2019
Contributor
Author
|
@stanleygjones @paulyoung @chenyan-dfinity @krzysztofwos Not for this PR, but to ponder, so we can follow up: Given that it is standard in OS X for /usr/bin to not be writeable — for any user, unless set in the system settings, and that it is not that uncommon apparently for /usr/local/bin/ to not exist, what do we want the user experience to be. Recall any other path we add we would need to have the user update their PATH. |
ghost
merged commit
dfinity-bot
added a commit
that referenced
this pull request
Apr 29, 2021
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@5b3dcb83...db03320a](rustsec/advisory-db@5b3dcb8...db03320) * [`7086fa22`](rustsec/advisory-db@7086fa2) Report rkyv vulnerability (issue rkyv[RustSec/advisory-db#113](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/113)) ([RustSec/advisory-db#877](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/877)) * [`db03320a`](rustsec/advisory-db@db03320) Assigned RUSTSEC-2021-0054 to rkyv ([RustSec/advisory-db#878](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/878))
mergify bot
pushed a commit
that referenced
this pull request
Apr 29, 2021
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@5b3dcb83...db03320a](rustsec/advisory-db@5b3dcb8...db03320) * [`7086fa22`](rustsec/advisory-db@7086fa2) Report rkyv vulnerability (issue rkyv[RustSec/advisory-db#113](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/113)) ([RustSec/advisory-db#877](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/877)) * [`db03320a`](rustsec/advisory-db@db03320) Assigned RUSTSEC-2021-0054 to rkyv ([RustSec/advisory-db#878](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/878))
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our only fallback was sudo, but we did not have a fail backup.