Merged
Conversation
checkpoint - e2e tests, e2e ic ref tests pass
ghost
marked this pull request as draft
added 28 commits
September 25, 2020 15:17
…n't need two levels)
ghost
marked this pull request as ready for review
Author
|
I'm confident that this works, but I also think it would be reasonable not to merge it until after we release dfx 0.7.0. |
ghost
commented
Oct 14, 2020
ghost
linked an issue
5 tasks
p-shahi
reviewed
Oct 26, 2020
p-shahi
approved these changes
Oct 26, 2020
This was referenced Feb 16, 2021
dfinity-bot
added a commit
that referenced
this pull request
Oct 1, 2021
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@54d10b40...6724be0e](rustsec/advisory-db@54d10b4...6724be0) * [`a59b58df`](rustsec/advisory-db@a59b58d) nix::unistd::getgrouplist buffer overflow ([RustSec/advisory-db#1060](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1060)) * [`6724be0e`](rustsec/advisory-db@6724be0) Assigned RUSTSEC-2021-0119 to nix ([RustSec/advisory-db#1066](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1066))
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2021
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@54d10b40...6724be0e](rustsec/advisory-db@54d10b4...6724be0) * [`a59b58df`](rustsec/advisory-db@a59b58d) nix::unistd::getgrouplist buffer overflow ([RustSec/advisory-db#1060](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1060)) * [`6724be0e`](rustsec/advisory-db@6724be0) Assigned RUSTSEC-2021-0119 to nix ([RustSec/advisory-db#1066](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1066))
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements #1020: rework
dfx startto use actors.Change in behavior:
replicaprocess exits unexpectedly,dfx startwill now start a new replica, and also restart the proxy webserver to forward to it. Previous behavior was to exit.Something to watch out for is that the process doesn't report a segfault in response to SIGINT/SIGTERM. I found a way to avoid this: stop the webserver before allowing the actor system to shut down.
The segfault behavior was introduced with the latest version of actix, to which we upgraded in order to pass some audit checks. The es-1020-gradual-master-merge branch demonstrates this. To see for yourself, run
dfx startand then stop it with Ctrl-C,kill -INT, orkill -TERM, and observe the following behavior:Anyway, when testing
dfx startand probably alsodfx replica, in addition to knowing that e2e tests pass it's a good idea to run them locally, press Ctrl-C, and make sure there is no message about a segfault.