-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ic-asset-ceritication): allow deleting assets from the asset router #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanosdev
force-pushed
the
nathan/allow-deleting-assets
branch
2 times, most recently
from
August 21, 2024 11:52
9408c3c
to
ac1dfa9
Compare
nathanosdev
changed the base branch from
main
to
nathan/request-response-builder
August 21, 2024 11:52
nathanosdev
force-pushed
the
nathan/allow-deleting-assets
branch
3 times, most recently
from
August 28, 2024 11:45
9ba866c
to
72111d9
Compare
nathanosdev
force-pushed
the
nathan/request-response-builder
branch
from
August 28, 2024 11:48
e904944
to
a43887c
Compare
nathanosdev
force-pushed
the
nathan/allow-deleting-assets
branch
2 times, most recently
from
August 28, 2024 11:50
1414616
to
a8a78f3
Compare
nathanosdev
force-pushed
the
nathan/allow-deleting-assets
branch
from
August 28, 2024 14:09
a8a78f3
to
8328f7e
Compare
nathanosdev
commented
Aug 28, 2024
nathanosdev
commented
Aug 28, 2024
nathanosdev
commented
Aug 28, 2024
nathanosdev
commented
Aug 28, 2024
packages/ic-response-verification/src/verification/verify_request_response_pair.rs
Show resolved
Hide resolved
przydatek
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! And very nice tests!
LGTM, thanks!
nathanosdev
force-pushed
the
nathan/allow-deleting-assets
branch
from
September 5, 2024 12:24
8328f7e
to
bb807cf
Compare
nathanosdev
force-pushed
the
nathan/allow-deleting-assets
branch
from
September 5, 2024 12:47
bb807cf
to
1042ef8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TT-415
Adds the ability to delete certified assets from the asset router.