Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ic-asset-ceritication): allow deleting assets from the asset router #356

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

nathanosdev
Copy link
Member

@nathanosdev nathanosdev commented Aug 19, 2024

TT-415

Adds the ability to delete certified assets from the asset router.

@nathanosdev nathanosdev self-assigned this Aug 19, 2024
@nathanosdev nathanosdev force-pushed the nathan/allow-deleting-assets branch 2 times, most recently from 9408c3c to ac1dfa9 Compare August 21, 2024 11:52
@nathanosdev nathanosdev changed the base branch from main to nathan/request-response-builder August 21, 2024 11:52
@nathanosdev nathanosdev force-pushed the nathan/allow-deleting-assets branch 3 times, most recently from 9ba866c to 72111d9 Compare August 28, 2024 11:45
@nathanosdev nathanosdev force-pushed the nathan/request-response-builder branch from e904944 to a43887c Compare August 28, 2024 11:48
@nathanosdev nathanosdev force-pushed the nathan/allow-deleting-assets branch 2 times, most recently from 1414616 to a8a78f3 Compare August 28, 2024 11:50
Base automatically changed from nathan/request-response-builder to main August 28, 2024 12:39
@nathanosdev nathanosdev marked this pull request as ready for review August 28, 2024 14:20
@nathanosdev nathanosdev requested a review from a team as a code owner August 28, 2024 14:20
Copy link
Contributor

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! And very nice tests!
LGTM, thanks!

packages/ic-asset-certification/src/asset_router.rs Outdated Show resolved Hide resolved
packages/ic-asset-certification/README.md Outdated Show resolved Hide resolved
packages/ic-http-certification/src/http/http_response.rs Outdated Show resolved Hide resolved
packages/ic-asset-certification/src/lib.rs Show resolved Hide resolved
@nathanosdev nathanosdev merged commit a247d4e into main Sep 5, 2024
6 checks passed
@nathanosdev nathanosdev deleted the nathan/allow-deleting-assets branch September 5, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants